New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704428 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression

Blocking:
issue 741083



Sign in to add a comment

Regression:Incomplete text is displayed for second option after click on show home button.

Reported by vku...@etouch.net, Mar 23 2017

Issue description

Chrome Version:59.0.3048.0 (Official Build)Revision 1af111915f36842841682091b8c6882cae410831-refs/heads/master@{#458590}(32/64-bit)
OS:Windows (7,8,10), Mac (10.11.6, 10.12.1, 10.12), Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings/
(2)Click on 'show home button' , observe the second option.

Actual: Incomplete text is displayed after click on show home button (i.e 'Enter custom web a...)

Expected: Complete text 'Enter custom web address' should be displayed after clicking on show home button.

This is a regression issue broken in 'M59' and below is the manual regression range
Good Build: 59.0.3047.0 
Bad Build: 59.0.3048.0 



 
ActualHome.mov
903 KB Download

Comment 1 by vku...@etouch.net, Mar 23 2017

Labels: -OS-Linux
Correction:
Above issue is not seen on Linux OS for chrome version 59.0.3048.0 (Official Build)
Labels: hasbisect-per-revision
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Information:
---------------------
You are probably looking for a change made after 458459 (known good), but no later than 458460 (first known bad).

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/4a42d386112ff65fe17baa0c633e5ccc44989aa5..6e84ac1cc45e551a53b8381068cb91f0263f6b66

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2764543002

stevenjb@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Cc: steve...@chromium.org dbeam@chromium.org
Owner: bettes@chromium.org
I don't see this on chrome os with the default font size, but I do with fonts set to 'Very large'.

bettes@ - you requested a width of 200px for this input, but it could be much wider. Should we bump this up to 300px or 400px (especially given that many urls won't fit in the current size).


Comment 4 by bettes@chromium.org, Mar 31 2017

Labels: -Pri-2 Pri-3
We should revisit after launch. Text is visible up until "extra large" so I think the urgency here is akin to a Pri3. Thanks!
Labels: -M-59

Comment 6 by dpa...@chromium.org, Jul 11 2017

Labels: Proj-MaterialDesign-WebUI

Comment 7 by dpa...@chromium.org, Jul 11 2017

Blocking: 741083
Owner: ----
Status: Untriaged (was: Assigned)
Clearing my ownership of P3 UI>Settings bugs. Feel free to re-assign once triaging is complete. 
Labels: OS-Chrome OS-Linux
Owner: namratakannan@chromium.org
Status: Assigned (was: Untriaged)
@namratakannan:
Given that there is plenty of space on the right, I think it makes sense to make the text input a bit longer. Posting some options below. WDYT?

200px is current width. 50% and 100% are suggestions showing a longer input.
200px.png
39.2 KB View Download
50_percent.png
39.6 KB View Download
100_percent.png
39.4 KB View Download
50% looks fine, 100% feels weird because of the indentation.

Cc: aee@chromium.org namratakannan@chromium.org
Labels: -Pri-3 Pri-2
Owner: ----
Status: Available (was: Assigned)
Thanks! Marking this as available.
Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb0ea28e343c0288bbb57b5224c8eaf13e5156f

commit 7fb0ea28e343c0288bbb57b5224c8eaf13e5156f
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 20 01:12:10 2018

Settings WebUI: Make home URL text input longer.

Instead of having a fixed 200px width, make it occupy 50% of the
available space.

Bug:  704428 
Change-Id: I8f647da9c2fee631548cbb0691733ade82fb7230
Reviewed-on: https://chromium-review.googlesource.com/1144137
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576745}
[modify] https://crrev.com/7fb0ea28e343c0288bbb57b5224c8eaf13e5156f/chrome/browser/resources/settings/appearance_page/home_url_input.html

Status: Fixed (was: Started)
Labels: TE-Verified-M69 TE-Verified-69.0.3497.0
Update:-

Re-tested this issue on Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS)OS using latest Chrome Canary build# 69.0.3497.0 and issue is fixed. Hence adding TE-Verified labels. 

Please find below attached screen-cast for reference.

Thanks..!
Fixed_Result.mp4
367 KB View Download

Sign in to add a comment