New issue
Advanced search Search tips

Issue 704405 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

chrome presubmit bot fails for at least V8, skia and pdfium rolls

Project Member Reported by kozyatinskiy@chromium.org, Mar 23 2017

Issue description

What steps will reproduce the problem?
(1) git cl patch https://codereview.chromium.org/2775503004/ -b v8-roll
(2) git cl presubmit

What is the expected result?
finished without errors.

It blocks auto rollers:
https://codereview.chromium.org/2775503004/
https://codereview.chromium.org/search?closed=1&owner=catapult-deps-roller%40chromium.org&reviewer=&cc=&repo_guid=&base=&project=&private=1&commit=1&created_before=&created_after=&modified_before=&modified_after=&order=&format=html&keys_only=False&with_messages=False&cursor=&limit=30
...

What happens instead?
Traceback (most recent call last):
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/git_cl.py", line 5699, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/git_cl.py", line 5681, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/git_cl.py", line 4476, in CMDpresubmit
    change=cl.GetChange(base_branch, None))
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/git_cl.py", line 1519, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/presubmit_support.py", line 1293, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/usr/local/google/home/kozyatinskiy/code/depot_tools/presubmit_support.py", line 1203, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 2389, in CheckChangeOnCommit
  File "<string>", line 2123, in _CommonChecks
  File "<string>", line 1123, in _CheckAddedDepsHaveTargetApprovals
  File "<string>", line 1084, in _CalculateAddedDeps
  File "<string>", line 127, in <module>
NameError: name 'Var' is not defined
 
Cc: dcheng@chromium.org
Owner: ksakamoto@chromium.org
Status: Assigned (was: Untriaged)
https://codereview.chromium.org/2759593003 touched code around _CheckAddedDepsHaveTargetApprovals. Let me revert it.
I checked - it helps locally.
Status: Fixed (was: Assigned)
Reverted https://codereview.chromium.org/2772693002/

Comment 4 by dcheng@chromium.org, Mar 23 2017

Sorry for the trouble, and thanks for the revert.

Sign in to add a comment