ReadingList tests testVisibleButtons... are failing |
|||||||
Issue description4 tests appear to have failed after an MDC roll. I wasn't sure if anything was dependent upon this since it I noticed several hours after it landed, so I disabled the tests, rather than revert. It broke between these revs d1c55391bd4f08ce3f5f57c4c6e7d3cb50ff6e51..dac09c03b9f3cc44adf71e8836f6bebabec7a61d The disabled tests are: testVisibleButtonsEditingModeEmptySelection testVisibleButtonsOnlyReadEntrySelected testVisibleButtonsOnlyUnreadEntrySelected testVisibleButtonsMixedEntriesSelected
,
Mar 23 2017
,
Mar 23 2017
Assigning to lpromero@ as it is caused by a MDC roll.
,
Mar 23 2017
Gauthier, can you see if the Reading List EG test target could be made part of the upstream CQ and waterfall?
,
Mar 23 2017
I think we have no EG tests upstream on purpose. baxley@, can you confirm?
,
Mar 23 2017
,
Mar 23 2017
Louis, I mentioned it in email, but I'm in process of moving some EG tests to the main waterfall. They are on the EarlGrey bot on fyi, which iOS sheriffs are supposed to watch. Once it gets on main, then upstream sheriffs will monitor it and it will be on the main page. We also plan to put some things on the CQ. The reading list tests aren't on the upstream FYI bot. Is there any reason for this?
,
Mar 23 2017
I can’t think of any reason but an oversight. Gauthier?
,
Mar 23 2017
Must be an oversight.
,
Mar 23 2017
not a problem. I'll add it now. It may not have helped if iOS sheriffs weren't monitoring the FYI bot for this case. But they have watched it sometimes!
,
Mar 23 2017
Thinking about it, they were probably not enabled because Reading List was not enabled by default on the bot. It should be the case with M57, so it is OK to enable them now.
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d38667879bbe7d246540f9275532da06d82319e commit 7d38667879bbe7d246540f9275532da06d82319e Author: baxley <baxley@chromium.org> Date: Thu Mar 23 15:52:04 2017 Add reading list tests to upstream FYI and try bots. These tests should be running upstream. BUG= 704401 Review-Url: https://codereview.chromium.org/2776443002 Cr-Commit-Position: refs/heads/master@{#459095} [modify] https://crrev.com/7d38667879bbe7d246540f9275532da06d82319e/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/7d38667879bbe7d246540f9275532da06d82319e/ios/build/bots/chromium.mac/ios-simulator-eg.json
,
Mar 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2b51af46553840e92c3b1f860b6ba13678c7852 commit d2b51af46553840e92c3b1f860b6ba13678c7852 Author: lpromero <lpromero@chromium.org> Date: Thu Mar 23 17:54:17 2017 Reenable History and Reading List EG tests. The tests were disabled because of an underling issue fixed in https://codereview.chromium.org/2756193003/. BUG= 704403 , 704401 R=gambard@chromium.org Review-Url: https://codereview.chromium.org/2774633002 Cr-Commit-Position: refs/heads/master@{#459136} [modify] https://crrev.com/d2b51af46553840e92c3b1f860b6ba13678c7852/ios/chrome/browser/ui/history/history_ui_egtest.mm [modify] https://crrev.com/d2b51af46553840e92c3b1f860b6ba13678c7852/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
,
Mar 23 2017
,
Jan 24 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 23 2017