New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704401 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
No longer actively working on Chrom...
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

ReadingList tests testVisibleButtons... are failing

Project Member Reported by baxley@chromium.org, Mar 23 2017

Issue description

4 tests appear to have failed after an MDC roll. I wasn't sure if anything was dependent upon this since it I noticed several hours after it landed, so I disabled the tests, rather than revert.

It broke between these revs d1c55391bd4f08ce3f5f57c4c6e7d3cb50ff6e51..dac09c03b9f3cc44adf71e8836f6bebabec7a61d

The disabled tests are:
testVisibleButtonsEditingModeEmptySelection
testVisibleButtonsOnlyReadEntrySelected 
testVisibleButtonsOnlyUnreadEntrySelected
testVisibleButtonsMixedEntriesSelected


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/533f43506d597e4f761832fea3e5e4078a8b7c60

commit 533f43506d597e4f761832fea3e5e4078a8b7c60
Author: baxley <baxley@chromium.org>
Date: Thu Mar 23 04:19:28 2017

Disable 4 reading list tests.

Several reading list tests to test visibility of buttons
are failing on every platform.

BUG= 704401 
TBR=jif

Review-Url: https://codereview.chromium.org/2769963002
Cr-Commit-Position: refs/heads/master@{#459001}

[modify] https://crrev.com/533f43506d597e4f761832fea3e5e4078a8b7c60/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

Comment 2 by jif@chromium.org, Mar 23 2017

Owner: gambard@chromium.org
Cc: gambard@chromium.org
Owner: lpromero@chromium.org
Assigning to lpromero@ as it is caused by a MDC roll.
Status: Started (was: Assigned)
Gauthier, can you see if the Reading List EG test target could be made part of the upstream CQ and waterfall?
Cc: baxley@chromium.org
I think we have no EG tests upstream on purpose.
baxley@, can you confirm?

Comment 7 by baxley@chromium.org, Mar 23 2017

Louis, I mentioned it in email, but I'm in process of moving some EG tests to the main waterfall. They are on the EarlGrey bot on fyi, which iOS sheriffs are supposed to watch.

Once it gets on main, then upstream sheriffs will monitor it and it will be on the main page. We also plan to put some things on the CQ.

The reading list tests aren't on the upstream FYI bot. Is there any reason for this?
I can’t think of any reason but an oversight. Gauthier?
Must be an oversight.
not a problem. I'll add it now. It may not have helped if iOS sheriffs weren't monitoring the FYI bot for this case. But they have watched it sometimes!
Thinking about it, they were probably not enabled because Reading List was not enabled by default on the bot. It should be the case with M57, so it is OK to enable them now.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d38667879bbe7d246540f9275532da06d82319e

commit 7d38667879bbe7d246540f9275532da06d82319e
Author: baxley <baxley@chromium.org>
Date: Thu Mar 23 15:52:04 2017

Add reading list tests to upstream FYI and try bots.

These tests should be running upstream.

BUG= 704401 

Review-Url: https://codereview.chromium.org/2776443002
Cr-Commit-Position: refs/heads/master@{#459095}

[modify] https://crrev.com/7d38667879bbe7d246540f9275532da06d82319e/ios/build/bots/chromium.fyi/EarlGreyiOS.json
[modify] https://crrev.com/7d38667879bbe7d246540f9275532da06d82319e/ios/build/bots/chromium.mac/ios-simulator-eg.json

Status: Fixed (was: Started)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment