New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704400 link

Starred by 0 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

shard_client_integration_test is broken

Project Member Reported by akes...@chromium.org, Mar 23 2017

Issue description

$ python ./scheduler/shard/shard_client_integration_tests.py 
WARNING:root:/usr/local/google/home/akeshet/chromiumos/src/third_party/autotest/files/scheduler/scheduler_models.py:183: DeprecationWarning: object() takes no parameters
  return super(DBObject, cls).__new__(cls, id=id, **kwargs)

INFO:root:Setting leased = False for the hosts that match {'hostname__in': [u'host1', u'host2', u'host3', u'host4', u'host5', u'host6', u'host7', u'host8', u'host9']}
INFO:root:HQE: 1, for job: 1 and host: no host has status:Queued -> Completed
DEBUG:root:Update Field Complete
DEBUG:root:HQE Set Status Complete
EINFO:root:Setting leased = False for the hosts that match {'hostname__in': [u'host1', u'host2', u'host3', u'host4', u'host5', u'host6', u'host7', u'host8', u'host9']}
.INFO:root:Setting leased = False for the hosts that match {'hostname__in': [u'host1', u'host2', u'host3', u'host4', u'host5', u'host6', u'host7', u'host8', u'host9']}
INFO:root:HQE: 1, for job: 1 and host: no host has status:Queued -> Completed
DEBUG:root:Update Field Complete
DEBUG:root:HQE Set Status Complete
EINFO:root:Setting leased = False for the hosts that match {'hostname__in': [u'host1', u'host2', u'host3', u'host4', u'host5', u'host6', u'host7', u'host8', u'host9']}
.
======================================================================
ERROR: testCompleteStatusBasic (__main__.ShardClientIntegrationTest)
Test that complete jobs are uploaded properly.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./scheduler/shard/shard_client_integration_tests.py", line 51, in testCompleteStatusBasic
    job_ids, host_ids = client._get_known_ids()
AttributeError: 'ShardClient' object has no attribute '_get_known_ids'

======================================================================
ERROR: testOnlyShardId (__main__.ShardClientIntegrationTest)
Test that setting only the shardid prevents the job from upload.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./scheduler/shard/shard_client_integration_tests.py", line 92, in testOnlyShardId
    job_ids, host_ids = client._get_known_ids()
AttributeError: 'ShardClient' object has no attribute '_get_known_ids'

----------------------------------------------------------------------
Ran 4 tests in 2.134s

FAILED (errors=2)



git bisect reveals that it was broken by https://chromium-review.googlesource.com/#/c/357330/
 
Actually, that was not the bad CL. That was just the CL that made failures visible without -v flag. Tracking down the real culprit now...
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6358168009dad043ff738fb1cdfb31e2ed2a2ba6

commit 6358168009dad043ff738fb1cdfb31e2ed2a2ba6
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Mar 23 08:35:16 2017

autotest: fix shard_client_integration_test

BUG= chromium:704400 
TEST=shard_client_integration_test

Change-Id: I67b55b410270b27158b449088272bd2294e73951
Reviewed-on: https://chromium-review.googlesource.com/457928
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/6358168009dad043ff738fb1cdfb31e2ed2a2ba6/scheduler/shard/shard_client_integration_tests.py

Status: Fixed (was: Untriaged)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment