New issue
Advanced search Search tips

Issue 704397 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Disable permission embargo for plugins on desktop

Project Member Reported by dominickn@chromium.org, Mar 23 2017 
Plugins permission is just use for Flash on desktop, but Html5ByDefault should ensure that a permission prompt is only shown when a user is directly trying to run Flash. We should disable permission embargo for Flash and defer entirely to Html5ByDefault's handling.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4beb9d55d0efc81b8a2a2a91fb88266d4156a35b

commit 4beb9d55d0efc81b8a2a2a91fb88266d4156a35b
Author: dominickn <dominickn@chromium.org>
Date: Tue Mar 28 03:47:07 2017

Disable permissions embargo for plugins.

Html5ByDefault triggers prompts to enable Flash of the type
CONTENT_SETTINGS_TYPE_PLUGINS. Otherwise, sites can't trigger the
plugins prompt, so it doesn't make sense to include it under embargo
(and users may get confused if we embargo plugins permission prompts).

This CL stops embargo from being applied to plugins prompts. A test is
added to verify the behaviour.

BUG= 704397 

Review-Url: https://codereview.chromium.org/2772513004
Cr-Commit-Position: refs/heads/master@{#460006}

[modify] https://crrev.com/4beb9d55d0efc81b8a2a2a91fb88266d4156a35b/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/4beb9d55d0efc81b8a2a2a91fb88266d4156a35b/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc

Comment 2 by dominickn@chromium.org, Mar 31 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment