New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704396 link

Starred by 7 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Failure step summary is not useful (bad UI)

Project Member Reported by tansell@chromium.org, Mar 23 2017

Issue description

Currently when a try run fails, you get the following final step;
------
Failure reason ( 4 ms ) Failure reason
  stdio
  reason
------

See https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/414721 for example.

There are numerous failings here;

 * The step is green despite it indicating that the whole thing failed.
 * Clicking the stdio link gives you a message about "log dog". 
 * Clicking the reason link gives you;
-----
3 out of 3 aggregated steps failed. Failures: Step('unit_tests (retry summary)') failed with return_code 1, Step('browser_side_navigation_unit_tests (retry summary)') failed with return_code 1, Step('site_per_process_unit_tests (retry summary)') failed with return_code 1
-----

This is a horrible UI. I would be surprised if people even looked at this step...

Bunch of important questions;

 * Why do I have to click something to see the important message?
 * Why doesn't the message include links to the failures?
 * Why do I care about the return code?
 * What is the action item from seeing this output?

A developer shouldn't need to understand how recipies or buildbot works to understand the failure.

 
Labels: -Restrict-View-Google
Cc: iannucci@chromium.org
Labels: Pri-2 Type-Feature
Status: Available (was: Untriaged)
triaging; this bug report is totally accurate, the UI here sucks. Unfortunately we don't have enough horsepower on the team right now to work on it immediately.

Once we're fully milo-ified (i.e. and no longer beholden to buildbot's terrible `@@@BOGUS_ANNOTATION@@@` malarky, we should design a real UI for recipes. We've been stuck with buildbot's scraps for years.

That said, if someone wants to pick this up and make some minor improvements (such as turning some steps here red), that's worthwhile.
Issue 687563 has been merged into this issue.
Cc: phajdan.jr@chromium.org d...@chromium.org
 Issue 630060  has been merged into this issue.
Project Member

Comment 5 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mar...@chromium.org, May 21 2018

Cc: -phajdan.jr@chromium.org -d...@chromium.org -mcgreevy@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment