New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704395 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Hide all the triggered steps inside a single "triggered" step

Project Member Reported by tansell@chromium.org, Mar 23 2017

Issue description

Currently every test run on swarming has a [trigger] and the result step. See https://luci-milo.appspot.com/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/414728 for example.

As a developer, I only really care about the result step because I want to see why something failed / succeeded that I didn't expect.

We should collect all the triggered steps up into a single nested step which is closed by default. This will make it easier for a developer to actually find / see the steps they care about.

This would also significantly reduce the amount of scrolling needed on the build page.
 
Labels: -Restrict-View-Google
Components: -Infra Infra>Platform>Swarming

Comment 3 by mar...@chromium.org, Mar 24 2017

Strictly speaking it's not Swarming itself, it's purely recipe work.

Comment 4 by estaab@chromium.org, Mar 26 2017

We're also considering compressing consecutive green steps (click to expand), which would solve this problem indirectly. I do like the idea of having the triggers as nested steps but I'm less sure how doable that is.

Comment 5 by estaab@chromium.org, Mar 26 2017

Labels: Pri-3
Status: Available (was: Untriaged)
It seem very dooable from what I can see?

I actually have a proof of concept that does a similar thing for the isolate steps (once we use exparchive everywhere, we get an individual isolate step per task in the same way we get individual trigger steps).
Components: -Infra>Platform>Recipes Infra>Client>Chrome
This is also in the "buildbot UI is not designed for the things we use it for" problem space, but I think this can be done entirely in the swarming and/or chromium module(s) for now.
 Issue 614760  has been merged into this issue.
Cc: dpranke@chromium.org jparent@chromium.org iannucci@chromium.org estaab@chromium.org
Components: -Infra>Client>Chrome -Infra>Platform>Swarming Infra>Platform>Milo
This is working on the buildbot pages but not on milo -- all the trigger steps are hidden under the "test_pre_run" step.

Compare 
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/61809
to
https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Tests/61809

It seems Milo doesn't support rendering of the nested steps as being nested. Assigning to the milo team to figure out what they should do.
Cc: phosek@chromium.org
We have the same issue in Fuchsia. Milo renders nested steps as inline, not as collapsible same as Buildbot did. This was originally implemented as a workaround in 656212, but we'd like to have a proper support for collapsible nested steps.
Cc: efoo@chromium.org
Labels: -Pri-3 Pri-1 Type-Bug-Regression
I'm putting this on the radar for high-priority migration bugs.

Comment 12 by efoo@google.com, Jan 14 2018

Labels: LUCI-M0-Backlog LUCI-KnownIssues-UI REQBY-LUCI-M5-GASupport

Comment 13 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 14 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog

Comment 15 by efoo@chromium.org, Feb 15 2018

Labels: -REQBY-LUCI-M5-GASupport LUCI-Blocker-Chromium
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment