New issue
Advanced search Search tips

Issue 704384 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove webkit-patch rebaseline-server.

Project Member Reported by qyears...@chromium.org, Mar 23 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16541cdc9d7b32bdd1ce60b1031419f04e619814

commit 16541cdc9d7b32bdd1ce60b1031419f04e619814
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Tue Jan 23 22:07:55 2018

Remove webkit-patch rebaseline-server.

This has probably be unused for sometime.
We proposed removing it early last year:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/J-oJz1zL-HA

Relatedly, webkit-patch layout-tests-server can be removed in another CL.

Bug:  704384 
Change-Id: I706835aac9cc0f7c1d5c80b5fffb6966352da556
Reviewed-on: https://chromium-review.googlesource.com/847641
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531366}
[delete] https://crrev.com/a9d49a321edf59c960e2109abb66371d59c38572/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server.py
[delete] https://crrev.com/a9d49a321edf59c960e2109abb66371d59c38572/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server_unittest.py
[modify] https://crrev.com/16541cdc9d7b32bdd1ce60b1031419f04e619814/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75c0d2f76be40e5f9d4bf0e51220c6b1bf190805

commit 75c0d2f76be40e5f9d4bf0e51220c6b1bf190805
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Thu Jan 25 18:52:28 2018

Remove webkit-patch layout-tests-server.

Now webkit-patch rebaseline-server is removed in
https://crrev.com/c/847641.

layout-tests-server is likely also unused, and it would
be good to reduce the surface area and quantity of code
in webkitpy if possible.

Bug:  704384 
Change-Id: I518153ae01c36d1e34433dc38c5ebea9b87cc869
Reviewed-on: https://chromium-review.googlesource.com/883613
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531963}
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/layout_tests_server.py
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/__init__.py
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/main.js
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layout_tests_server.py
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler.py
[delete] https://crrev.com/9aa4d2ce7228d359cd02f91866c1364cbfb14823/third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflection_handler_unittest.py
[modify] https://crrev.com/75c0d2f76be40e5f9d4bf0e51220c6b1bf190805/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py

Owner: qyears...@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment