Remove the Blink commit announcer. |
|||
Issue descriptionRelated post on blink-dev: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/HZHnKZxhZkY Code is at: https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/ The advantage of removing the blink commit announcer would be so that we don't have to maintain it in the future. Based on the discussion in that thread on blink-dev, it sounds like it might be a good time to merge the #blink channel into #chromium anyway, and then the Blink commit announcer will be unused.
,
Apr 4 2017
Where is this running? I searched infra/build but couldn't find it.
,
Apr 4 2017
I'm not sure -- I think it's likely running on somebody's workstation, but I'm not sure who, myself. Although, this is more about the task of removing the code from the source tree and not supporting it anymore, so it may not be essential to know where it has been running.
,
Apr 4 2017
@alancutter - is this still you?
,
Apr 5 2017
I'm happy to do the code removal and shut the bot down.
,
Apr 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7afabff17431ee27e1dbe217849b7ecfc78c258e commit 7afabff17431ee27e1dbe217849b7ecfc78c258e Author: alancutter <alancutter@chromium.org> Date: Wed Apr 05 03:22:27 2017 Remove the commit-announcer command from webkit-patch The commit announcer commit-bot in the #blink IRC channel is deprecated in favour of merging #blink with #chromium. This patch removes the commit announcer code as it is no longer used. BUG= 704383 Review-Url: https://codereview.chromium.org/2797913002 Cr-Commit-Position: refs/heads/master@{#461965} [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/irc/__init__.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/irc/ircbot.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/irc/irclib.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/__init__.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer_unittest.py [delete] https://crrev.com/e73759e7b2870df901e45294e19bdce9a47a60f6/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commit_announcer.py [modify] https://crrev.com/7afabff17431ee27e1dbe217849b7ecfc78c258e/third_party/WebKit/Tools/Scripts/webkitpy/tool/webkit_patch.py
,
Apr 5 2017
[Wednesday 13:25] <commit-bot> https://crrev.com/461965 alancutter@chromium.org committed "Remove the commit-announcer command from webkit-patch"
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3b50ff509d54ca8b926fede2661af067d4a16db commit f3b50ff509d54ca8b926fede2661af067d4a16db Author: qyearsley <qyearsley@chromium.org> Date: Fri Apr 21 04:50:33 2017 Update webkitpy/thirdparty/README.chromium to reflect the fact that ircbot has been removed. BUG= 704383 Review-Url: https://codereview.chromium.org/2829193002 Cr-Commit-Position: refs/heads/master@{#466263} [modify] https://crrev.com/f3b50ff509d54ca8b926fede2661af067d4a16db/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/README.chromium |
|||
►
Sign in to add a comment |
|||
Comment 1 by qyears...@chromium.org
, Apr 4 2017