DevTools: console crashes when trying to log generator |
||||||
Issue description
Chrome Version : 57.0.2987.98
What steps will reproduce the problem?
1. Open devtools, create a new snippet with the following code:
function *foo() {
yield 10;
yield 20;
}
2. Evaluate a snippet.
3. In console, evaluate 'foo()'
Actual: console throws an exception and doesn't recover
Expected: no exception is thrown.
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/088e4a90947078a9dd6db43a21770ad14d0b9e43 commit 088e4a90947078a9dd6db43a21770ad14d0b9e43 Author: luoe <luoe@chromium.org> Date: Fri Mar 24 00:26:03 2017 DevTools: format generator objects as objects Objects of type 'generator' incorrectly went through the function formatter. Now they do go through the regular object formatter. BUG= 704380 Review-Url: https://codereview.chromium.org/2769973004 Cr-Commit-Position: refs/heads/master@{#459298} [modify] https://crrev.com/088e4a90947078a9dd6db43a21770ad14d0b9e43/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt [modify] https://crrev.com/088e4a90947078a9dd6db43a21770ad14d0b9e43/third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html [modify] https://crrev.com/088e4a90947078a9dd6db43a21770ad14d0b9e43/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
,
Mar 27 2017
,
Mar 27 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
Your change is approved for M58. Please ensure that fix works in canary. If all looks good, merge ASAP so that it will be picked up for next Beta Release, RC cut on (Tuesday-03/28) at 4.00 PM PST.
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/541b24d277f0c1e514ddfc13a203af476c873219 commit 541b24d277f0c1e514ddfc13a203af476c873219 Author: luoe <luoe@chromium.org> Date: Mon Mar 27 22:07:05 2017 DevTools: format generator objects as objects Objects of type 'generator' incorrectly went through the function formatter. Now they do go through the regular object formatter. BUG= 704380 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2769973004 Cr-Commit-Position: refs/heads/master@{#459298} (cherry picked from commit 088e4a90947078a9dd6db43a21770ad14d0b9e43) Review-Url: https://codereview.chromium.org/2779703002 Cr-Commit-Position: refs/branch-heads/3029@{#443} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/541b24d277f0c1e514ddfc13a203af476c873219/third_party/WebKit/LayoutTests/inspector/console/console-format-es6-expected.txt [modify] https://crrev.com/541b24d277f0c1e514ddfc13a203af476c873219/third_party/WebKit/LayoutTests/inspector/console/console-format-es6.html [modify] https://crrev.com/541b24d277f0c1e514ddfc13a203af476c873219/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
,
Mar 29 2017
lushnikov@, It would be helpful if you provide us the sample html file / test case to check the issue. Thank you!!
,
Mar 29 2017
lushnikov@'s original repro steps are a suitable test. Alternatively, here is another: - Open a tab to https://jsfiddle.net/hr2uj1Lv/ - Open DevTools and go to the Console - Click the 'Run' button on the page to run the JSFiddle - If a new object was logged into the console, the fix is verified.
,
Mar 30 2017
luoe@, Thanks for the reply. Tested the issue on Linux Ubuntu 14.04 using chrome version#58.0.3029.41 with the steps mentioned in comment #8.Observed that the foo object is generated in dev tools after running the fiddle. As it is intended behaviour ,adding TE-Verified labels. Please find the attached screenshot for the same. Thanks!!
,
May 1 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lushnikov@chromium.org
, Mar 23 2017