We should calculate metrics about how much data usage is used by downloading Web Manifests on every page load https://codereview.chromium.org/2764893003/

We should tell the Web Lite team about this so that they can strip <link rel="manifest"> tags for web sites if they are not doing so already in order to reduce network data usage

Also as a general note, I think that downloading both the Web Manifest and the primary icon on page load sounds pretty crazy to me

c#3: Fetching the manifest and the primary icon on every page load is *exactly* how banners used to work prior to M54. See https://crrev.com/2024953005

Given than manifests are usually <1KB, and that we can hopefully cache after the first page load, I'm quite positive that the side effects will be quite minor. We can discuss behaviour for the extreme cases, but overall this doesn't seem like a big burden.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2d4ff6157a4d06bd06089b872e0bc8a81068853

commit c2d4ff6157a4d06bd06089b872e0bc8a81068853
Author: dominickn <dominickn@chromium.org>
Date: Wed Apr 05 03:27:29 2017

Allow the app banner installability check to run on page load.

This CL implements a feature to control when the app banner
installability check is run - when the site accumulates sufficient
engagement (current default), or on every page load. Significant
refactoring of the AppBannerManager's internal state and new tests are
added to support this functionality.

New metrics are introduced in the installable manager to measure the
state of the installability check when the Android menu / add to
homescreen menu item are used. These metrics will be used to measure the
impact of running app banner checks as they are now / on page load in
determining how often we know that a site is a PWA when the user
interacts with the menu.

BUG= 704369 

Review-Url: https://codereview.chromium.org/2778983005
Cr-Commit-Position: refs/heads/master@{#461967}

[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/BUILD.gn
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/android/banners/app_banner_manager_android.cc
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/android/banners/app_banner_manager_android.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/engagement/site_engagement_service.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/installable/installable_manager_browsertest.cc
[add] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/installable/installable_metrics.cc
[add] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/browser/installable/installable_metrics.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/common/chrome_features.cc
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/chrome/common/chrome_features.h
[modify] https://crrev.com/c2d4ff6157a4d06bd06089b872e0bc8a81068853/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f715aee7d56fd113ac152d5e0b34dd1ece3ff6

commit 07f715aee7d56fd113ac152d5e0b34dd1ece3ff6
Author: dominickn <dominickn@chromium.org>
Date: Thu May 04 06:08:45 2017

Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics.

This CL ensures that the NOT_STARTED state is recorded separately from
the STOPPED_BEFORE_COMPLETION state in the installability menu-open
check metrics.

BUG= 704369 

Review-Url: https://codereview.chromium.org/2844383004
Cr-Commit-Position: refs/heads/master@{#469283}

[modify] https://crrev.com/07f715aee7d56fd113ac152d5e0b34dd1ece3ff6/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/07f715aee7d56fd113ac152d5e0b34dd1ece3ff6/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/07f715aee7d56fd113ac152d5e0b34dd1ece3ff6/chrome/browser/installable/installable_metrics.h

I'd like to merge #6 to M59. This is a metrics focused change to help improve one of our UMA stats.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdbec7de19e3eee6486e0f6607550c914e2f4083

commit bdbec7de19e3eee6486e0f6607550c914e2f4083
Author: Dominick Ng <dominickn@chromium.org>
Date: Mon May 08 05:53:20 2017

Split the NOT_STARTED and STOPPED_BEFORE_COMPLETION installability metrics.

This CL ensures that the NOT_STARTED state is recorded separately from
the STOPPED_BEFORE_COMPLETION state in the installability menu-open
check metrics.

BUG= 704369 

Review-Url: https://codereview.chromium.org/2844383004
Cr-Commit-Position: refs/heads/master@{#469283}
(cherry picked from commit 07f715aee7d56fd113ac152d5e0b34dd1ece3ff6)

Review-Url: https://codereview.chromium.org/2872483002 .
Cr-Commit-Position: refs/branch-heads/3071@{#442}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/bdbec7de19e3eee6486e0f6607550c914e2f4083/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/bdbec7de19e3eee6486e0f6607550c914e2f4083/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/bdbec7de19e3eee6486e0f6607550c914e2f4083/chrome/browser/installable/installable_metrics.h

Couple of bugs to fix in this metric

 - include sites which are not secure, in incognito, or in a non main frame to be counted as non-PWAs.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de8fc20eed0ffe8ca8c35b918566b243aa1acd57

commit de8fc20eed0ffe8ca8c35b918566b243aa1acd57
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Oct 06 08:23:01 2017

Move additional banner eligibility checking from AppBannerManager to InstallableManager.

This CL moves the checking for HTTP, incognito profile, and non-main
frames from AppBannerManager to InstallableManager. This allows metrics
which care about the state of the installability check to pick up sites
that are ineligible due to one of these properties as being non-PWAs.

BUG= 704369 

Change-Id: I5d7abfcd99028ec9c426000580475020bac500de
Reviewed-on: https://chromium-review.googlesource.com/686079
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507007}
[modify] https://crrev.com/de8fc20eed0ffe8ca8c35b918566b243aa1acd57/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/de8fc20eed0ffe8ca8c35b918566b243aa1acd57/chrome/browser/installable/installable_manager.cc
[modify] https://crrev.com/de8fc20eed0ffe8ca8c35b918566b243aa1acd57/chrome/browser/installable/installable_manager.h
[modify] https://crrev.com/de8fc20eed0ffe8ca8c35b918566b243aa1acd57/chrome/browser/installable/installable_manager_browsertest.cc
[modify] https://crrev.com/de8fc20eed0ffe8ca8c35b918566b243aa1acd57/chrome/browser/installable/installable_params.h