New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704358 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.6% regression in system_health.memory_mobile at 458417:458450

Project Member Reported by jasontiller@chromium.org, Mar 23 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=704358

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgzIH0_goM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 23 2017

Cc: mvstan...@chromium.org
Owner: mvstan...@chromium.org

=== Auto-CCing suspected CL author mvstanton@chromium.org ===

Hi mvstanton@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : mvstanton
  Commit : 1e03479c64ab3dc41182f4d7017b1fb39ceffb27
  Date   : Tue Mar 21 08:56:56 2017
  Subject: [builtins] Array.prototype.filter implemented as a TurboFan code stub.

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_games/load_games_lazors
  Change       : 1.47% | 2179160.0 -> 2211252.0

Revision                           Result                  N
chromium@458416                    2179160 +- 0.0          6      good
chromium@458433                    2176307 +- 15190.2      6      good
chromium@458438                    2179080 +- 0.0          6      good
chromium@458440                    2179080 +- 0.0          6      good
chromium@458441                    2179080 +- 0.0          6      good
chromium@458441,v8@25f86ffea5      2179080 +- 0.0          6      good
chromium@458441,v8@48e08319ca      2176838 +- 15155.4      6      good
chromium@458441,v8@ed93e7c27b      2179644 +- 0.0          6      good
chromium@458441,v8@1e03479c64      2211259 +- 40.1663      6      bad       <--
chromium@458441,v8@6ec45d7495      2211252 +- 0.0          6      bad
chromium@458442                    2211259 +- 40.1663      6      bad
chromium@458450                    2211252 +- 0.0          6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.games.lazors system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8984376853317120544

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5781733670125568


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
Actual regression reproduced here is 35kib, smaller than our threshold for alerting. The graphs are really up and down, so I don't think there's a real regression here.

Sign in to add a comment