New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704353 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.8% regression in memory.top_10_mobile_stress at 458451:458514

Project Member Reported by jasontiller@chromium.org, Mar 23 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=704353

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgrLC19wkM


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 23 2017

Cc: liber...@chromium.org
Owner: liber...@chromium.org

=== Auto-CCing suspected CL author liberato@chromium.org ===

Hi liberato@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : liberato
  Commit : 3fbc8b7641ee4665f400dee3641e7362b581d09a
  Date   : Tue Mar 21 18:38:18 2017
  Subject: Improve transition between opaque and translucent compositor views.

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : memory.top_10_mobile_stress
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/background/after_http_search_yahoo_com_search__ylt_p_google
  Change       : 0.01% | 26368292.5714 -> 26365952.0

Revision             Result                   N
chromium@458450      26368293 +- 76347.1      14      good
chromium@458482      26042661 +- 1993305      14      good
chromium@458484      26489742 +- 981157       9       good
chromium@458485      26349568 +- 126910       6       good
chromium@458486      26514318 +- 998513       9       bad       <--
chromium@458490      26404181 +- 27578.4      6       bad
chromium@458499      26576213 +- 963364       6       bad
chromium@458514      26365952 +- 209497       14      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile_stress

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8984377151181117104

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5245057977810944


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
This bug is from before we set thresholds on memory alerts; most of these are < 100kib.

Sign in to add a comment