Proxy connection timeout should be configurable |
||||||||||||||||||||
Issue descriptionCurrently, the proxy connection timeout is set to 10 seconds for Android and iOS, and set to 30 seconds for other platforms. Establishing a connection to proxy involves DNS resolution, transport connection establishment (using TCP/TLS or QUIC), and certificate exchange for secure proxies. For users on slow connections with high RTTs, all these steps can together take more than 10 seconds (e.g., see https://crbug.com/672959 ). This results in Chrome being unable to connect to proxies on slow connection. We should experiment with making the proxy connection timeout configurable (based on current network quality) so that on slower connection, Chrome waits longer for connection to succeeds before falling over to the next proxy.
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cbf5c1bc96f24e9e660e538cdce3d00562626f4 commit 4cbf5c1bc96f24e9e660e538cdce3d00562626f4 Author: tbansal <tbansal@chromium.org> Date: Tue Mar 28 21:07:59 2017 Record the time duration for establishing proxy connection Different UMA histograms are used for secure and insecure proxies. Similarly, different histograms are used when the proxy connection was successful vs. when the connection attempt timed out. BUG= 704339 Review-Url: https://codereview.chromium.org/2768173002 Cr-Commit-Position: refs/heads/master@{#460216} [modify] https://crrev.com/4cbf5c1bc96f24e9e660e538cdce3d00562626f4/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/4cbf5c1bc96f24e9e660e538cdce3d00562626f4/net/http/http_proxy_client_socket_wrapper.cc [modify] https://crrev.com/4cbf5c1bc96f24e9e660e538cdce3d00562626f4/net/http/http_proxy_client_socket_wrapper.h [modify] https://crrev.com/4cbf5c1bc96f24e9e660e538cdce3d00562626f4/tools/metrics/histograms/histograms.xml
,
Mar 29 2017
,
Apr 30 2017
If you haven't already, let's get an experiment going in M-60. aposner@: This could affect usability both positively (faster timeouts and fallback and more connections using a configured proxy) and negatively (users could wait longer to fall back to a working connection.) We should work out metrics to track.
,
May 1 2017
The experiment has not started yet. The last CL added a bunch of new UMA metrics to better understand the proxy connection behavior. Yup, planning to do this for M-60.
,
May 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d commit 10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d Author: tbansal <tbansal@chromium.org> Date: Fri May 26 05:23:04 2017 Expose transport RTT estimate from Network Quality Estimator (NQE) This will later be used to set proxy connection timeouts. BUG= 704339 Review-Url: https://codereview.chromium.org/2911473002 Cr-Commit-Position: refs/heads/master@{#474920} [modify] https://crrev.com/10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d/net/nqe/network_quality_estimator.h [modify] https://crrev.com/10cfdc03a41bf1808feaacb0a6648a6e6dc6d47d/net/nqe/network_quality_estimator_unittest.cc
,
May 30 2017
,
May 30 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bd4a950be946c149226979410c5cc934b1d8b47 commit 1bd4a950be946c149226979410c5cc934b1d8b47 Author: tbansal <tbansal@chromium.org> Date: Tue Jun 06 23:01:46 2017 Make NQE a derived class of NetworkQualityProvider NetworkQualityProvider provides functions to get network quality metrics, and to listen to changes in the network quality. This CL changes Network Quality Estimator (NQE) to be an implementation of Network Quality Provider (NQP). Long term, this allows callers to depend only on NQP when they only need to read the network quality, while the heavy-weight NQE can be used in other cases. BUG= 704339 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester TBR=petewil@chromium.org Review-Url: https://codereview.chromium.org/2927453002 Cr-Commit-Position: refs/heads/master@{#477452} [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/chrome/browser/io_thread.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/chrome/browser/net/nqe/ui_network_quality_estimator_service.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/chrome/browser/net/nqe/ui_network_quality_estimator_service.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/components/cronet/android/cronet_url_request_context_adapter.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/components/metrics/net/network_metrics_provider.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/components/offline_pages/core/background/network_quality_provider_stub.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/components/offline_pages/core/background/network_quality_provider_stub.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/content/browser/net/network_quality_observer_impl.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/content/browser/net/network_quality_observer_impl.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/content/public/browser/network_quality_observer_factory.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/BUILD.gn [add] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/effective_connection_type_observer.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/network_quality_estimator.cc [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/network_quality_estimator.h [modify] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/network_quality_estimator_unittest.cc [add] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/network_quality_provider.cc [add] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/network_quality_provider.h [add] https://crrev.com/1bd4a950be946c149226979410c5cc934b1d8b47/net/nqe/rtt_throughput_estimates_observer.h
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42 commit 16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42 Author: tbansal <tbansal@chromium.org> Date: Fri Jun 09 01:50:09 2017 Plumb NQP to context and to http_proxy_client_socket_pool Also, refactor http_proxy_client_socket_pool.cc so that proxy connection timeout is determined by a separate method. The next CL would use Network Quality Provider (NQP) to determine the proxy connection timeout in http_proxy_client_socket_pool. BUG= 704339 Review-Url: https://codereview.chromium.org/2899313006 Cr-Commit-Position: refs/heads/master@{#478159} [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/chrome/browser/profiles/profile_impl_io_data.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_network_session.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_network_session.h [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_proxy_client_socket_pool.h [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/http/http_stream_factory_impl_unittest.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/socket/client_socket_pool_manager_impl.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/socket/client_socket_pool_manager_impl.h [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/socket/ssl_client_socket_pool_unittest.cc [modify] https://crrev.com/16196a1e96e34678cbccaf3d0c0bea0dd2b4fb42/net/url_request/url_request_context_builder.cc
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a commit d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a Author: tbansal <tbansal@chromium.org> Date: Fri Jun 09 18:10:16 2017 Remove socket performance watcher factory from URL request context builder BUG= 704339 , 731723 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2924163003 Cr-Commit-Position: refs/heads/master@{#478334} [modify] https://crrev.com/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a/components/cronet/android/cronet_url_request_context_adapter.cc [modify] https://crrev.com/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a/net/url_request/url_request_context_builder.cc [modify] https://crrev.com/d8ef10af1a1f8f9adc05df7c796bd2944f2dfd3a/net/url_request/url_request_context_builder.h
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1 commit 0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1 Author: tbansal <tbansal@chromium.org> Date: Wed Jun 14 20:19:11 2017 Determine proxy connection timeout based on current network quality When the session is part of NetAdaptiveProxyConnectionTimeout field trial, the proxy connection timeout is determined based on the network quality and the field trial parameters. BUG= 704339 Review-Url: https://codereview.chromium.org/2932993002 Cr-Commit-Position: refs/heads/master@{#479486} [modify] https://crrev.com/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1/net/http/http_proxy_client_socket_pool.h [modify] https://crrev.com/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/0394a689e2f1a1dad9b7512b8d87f0fdc3ea87d1/net/nqe/network_quality_estimator_test_util.h
,
Jun 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d33cfaccbd9a7228537dc00db979930ad32646 commit 29d33cfaccbd9a7228537dc00db979930ad32646 Author: tbansal <tbansal@chromium.org> Date: Fri Jun 16 15:41:06 2017 Add field trial config for NetAdaptiveProxyConnectionTimeout Also, includes a fix to a small typo in DataReductionProxyFREPromo experiment config. BUG= 704339 Review-Url: https://codereview.chromium.org/2942833003 Cr-Commit-Position: refs/heads/master@{#480054} [modify] https://crrev.com/29d33cfaccbd9a7228537dc00db979930ad32646/testing/variations/fieldtrial_testing_config.json
,
Jul 13 2017
,
Aug 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/199d351448e84159f9c3a0fd0da55f0069575088 commit 199d351448e84159f9c3a0fd0da55f0069575088 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Aug 14 22:09:57 2017 Update the testing config for NetAdaptiveProxyConnectionTimeout Bug: 704339 Change-Id: I5d035425b839a260fc021ee44b667bcc3d708e7d Reviewed-on: https://chromium-review.googlesource.com/611328 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#494201} [modify] https://crrev.com/199d351448e84159f9c3a0fd0da55f0069575088/testing/variations/fieldtrial_testing_config.json
,
Aug 18 2017
,
Aug 22 2017
,
Aug 22 2017
Issue 672959 has been merged into this issue.
,
Aug 22 2017
,
Aug 22 2017
,
Sep 14 2017
,
Sep 14 2017
,
Sep 14 2017
Are you planning to merge this into M-62? I'd suggest bumping it to M-63.
,
Sep 14 2017
The Chromium code is already there in M-62. We need to wait for M-62 to get promoted to Beta to get some data.
,
Dec 1 2017
What's the status?
,
Dec 28 2017
I analyzed the last 28-day data (sorry, internal only link: http://shortn/_mnDbtrmkCI): For insecure proxies, transport RTT multipliers of 8 or 10 seem good. They both reduce the count of secure connections (Net.HttpProxy.ConnectLatency.Insecure.Success) by a small amount (~0.9%) while reducing the number of proxy connection timeouts (Net.HttpProxy.ConnectLatency.Insecure.TimedOut) by ~3.0%-5.1%. However, for secure proxies, all the 3 values of transport RTT multipliers experimented with (5, 8 and 10) show decrease in number of successful connections (Net.HttpProxy.ConnectLatency.Secure.Success) and an increase in number of timeouts (Net.HttpProxy.ConnectLatency.Secure.TimedOut). Two conclusions: 1. Experiment with different multipliers for secure and insecure proxies. It seems a similar logic exists here (although it looks buggy): https://cs.chromium.org/chromium/src/net/http/http_proxy_client_socket_pool.cc?rcl=f7d23283ffc6976c677eef75d13022b1dc8aefb9&l=251 2. Instead of transport RTT, experiment with using HTTP RTT since the HTTP RTT estimate has higher accuracy on non-posix platforms as well. This would enable us to extend the experiment to other platforms as well.
,
Jan 2 2018
What about doing something coarse using connection type? I worry that proxy connections tend to happen at session startup which is the worst case for NQE accuracy.
,
Jan 2 2018
tbansal@ explained offline: The experimentation has resulted in finding good timeouts for insecure proxy connections, but these constants are too short for secure proxy connections, which take longer to set up. The next step is thus to find good timeouts for secure connections.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec commit 10d1fd5f5871564c1a12e0ef15b952b6885dc4ec Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Jan 18 22:41:57 2018 Force recompute ECT when overriding the RTT values in NQE test class When RTT values are overridden in the network quality estimator test class, then the effective connection type is immediately recomputed. This makes it simpler to write tests. Without this change, the caller has to create and run a main frame URL request (which also forces recomputation of ECT). Bug: 704339 Change-Id: I4f92038a5577991a87d561ac4f4b2bcdd8172d79 TBR: mmenke@chromium.org,mpearson@chromium.org Reviewed-on: https://chromium-review.googlesource.com/874872 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#530314} [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/components/metrics/net/network_metrics_provider_unittest.cc [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/content/browser/net/network_quality_observer_impl_unittest.cc [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/net/nqe/network_quality_estimator.h [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/net/nqe/network_quality_estimator_test_util.cc [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/net/nqe/network_quality_estimator_test_util.h [modify] https://crrev.com/10d1fd5f5871564c1a12e0ef15b952b6885dc4ec/net/nqe/network_quality_estimator_unittest.cc
,
Jan 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/162eabe5e3f653d03d26a22aaefd5ba02df59dd2 commit 162eabe5e3f653d03d26a22aaefd5ba02df59dd2 Author: Tarun Bansal <tbansal@chromium.org> Date: Sat Jan 20 01:16:39 2018 Update net adaptive proxy timeout experiment logic * Allow different timeout thresholds for secure and insecure proxies. * Use HTTP RTT for computing the proxy connection timeout instead of the transport RTT. Bug: 704339 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6a2761a6dda90c53cdcc47045b05dcdc57e939e4 Reviewed-on: https://chromium-review.googlesource.com/845057 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#530713} [modify] https://crrev.com/162eabe5e3f653d03d26a22aaefd5ba02df59dd2/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/162eabe5e3f653d03d26a22aaefd5ba02df59dd2/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/162eabe5e3f653d03d26a22aaefd5ba02df59dd2/net/http/http_proxy_client_socket_pool.h [modify] https://crrev.com/162eabe5e3f653d03d26a22aaefd5ba02df59dd2/net/http/http_proxy_client_socket_pool_unittest.cc
,
Jan 23 2018
,
Jan 24 2018
M-65 merge request for the CL in comment #31 above. This is a pretty sage CL with code guarded behind a finch trial. This would allow us to use variable connection timeouts for HTTPS vs. HTTP proxies, (hopefully) resulting in more successful proxy connections.
,
Jan 25 2018
,
Jan 25 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409 commit 1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409 Author: Tarun Bansal <tbansal@chromium.org> Date: Thu Jan 25 19:29:12 2018 Update net adaptive proxy timeout experiment logic * Allow different timeout thresholds for secure and insecure proxies. * Use HTTP RTT for computing the proxy connection timeout instead of the transport RTT. Bug: 704339 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: I6a2761a6dda90c53cdcc47045b05dcdc57e939e4 Reviewed-on: https://chromium-review.googlesource.com/845057 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530713}(cherry picked from commit 162eabe5e3f653d03d26a22aaefd5ba02df59dd2) Reviewed-on: https://chromium-review.googlesource.com/887122 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#96} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409/net/http/http_network_transaction_unittest.cc [modify] https://crrev.com/1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409/net/http/http_proxy_client_socket_pool.h [modify] https://crrev.com/1f96202dc2446ed4fb28c2dd08c2d2d4b19e7409/net/http/http_proxy_client_socket_pool_unittest.cc
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5f7145889cd6583a38ec6f004cfd352826f6918 commit f5f7145889cd6583a38ec6f004cfd352826f6918 Author: Tarun Bansal <tbansal@chromium.org> Date: Wed Jan 31 06:19:24 2018 Update NetAdaptiveProxyConnectionTimeout for new experiment params Bug: 704339 Change-Id: Idce639d844d07252c2618ceb34a589964723ccc4 Reviewed-on: https://chromium-review.googlesource.com/891806 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#533216} [modify] https://crrev.com/f5f7145889cd6583a38ec6f004cfd352826f6918/testing/variations/fieldtrial_testing_config.json
,
Mar 21 2018
Refreshed during triage.
,
May 14 2018
AFAICT, looks like this issue should be closed. Many CLs landed including one merged into 65 tied to this issue. Suggest new bug for follow-on efforts.
,
May 14 2018
Not yet. Still working on the analysis of the experiment, and enabling it by default in Chrome.
,
May 22 2018
Refreshed during triage.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fea26dd3a42428fc20dc31eb3b1ce63e017b3f4a commit fea26dd3a42428fc20dc31eb3b1ce63e017b3f4a Author: Tarun Bansal <tbansal@chromium.org> Date: Wed May 30 06:22:37 2018 Change the default parameters for NetAdaptiveProxyConnectionTimeout Change the params of the experiment to match the params that we intend to launch with. Bug: 704339 Change-Id: I615e2cf2154da88e7a3ecc3faa0b39b49fcdbfcc Reviewed-on: https://chromium-review.googlesource.com/1066925 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#562750} [modify] https://crrev.com/fea26dd3a42428fc20dc31eb3b1ce63e017b3f4a/testing/variations/fieldtrial_testing_config.json
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44c2173921a08d18138a601b2628dcd42459c444 commit 44c2173921a08d18138a601b2628dcd42459c444 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Jun 12 22:18:31 2018 Enable the network quality adaptive proxy connection field trial by default The minimum proxy timeout is set to 8 seconds on Android and iOS; and 30 seconds on desktop. The maximum proxy timeout is set to 30 seconds on Android and iOS; and 60 seconds on desktop. It's still possible to change the minimum and maximum timeout values remotely using field trial. Bug: 704339 Change-Id: Id738215406ea80d63c0f1a0b350f4ac03b1711f3 Reviewed-on: https://chromium-review.googlesource.com/1092040 Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#566604} [modify] https://crrev.com/44c2173921a08d18138a601b2628dcd42459c444/net/http/http_proxy_client_socket_pool.cc [modify] https://crrev.com/44c2173921a08d18138a601b2628dcd42459c444/net/http/http_proxy_client_socket_pool_unittest.cc [modify] https://crrev.com/44c2173921a08d18138a601b2628dcd42459c444/testing/variations/fieldtrial_testing_config.json
,
Jun 13 2018
,
Jun 13 2018
Final experiment results here: https://docs.google.com/document/d/17BFSNPOzYQ7g6Y2DnIPiOdf_6ankCq3C-3KGOruvGs0/edit?usp=sharing |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by tbansal@chromium.org
, Mar 22 2017