power_manager: Don't install autosuspend udev rules on 'cros_embedded' devices |
||||||
Issue descriptionWith https://chromium-review.googlesource.com/#/c/434906/ we install udev rules to configure device autosuspend instead of using laptop-mode-tools. The CL assumes that laptop-mode-tools runs on all platforms, and therefore installs the rules on all targets. This is not correct, there are 'embedded' platforms like the OnHub routers which don't use laptop-mode-tools and enabling autosuspend caused at least one problem (b:36470502). Don't install the autosuspend rules when the USE flag 'cros_embedded' is set. This effectively reverts to the previous situation, since laptop-mode-tools is only included on non-embedded targets by virtual/target-chromium-os. A more fine grained solution will be needed if new 'embedded' devices are added that need autosuspend.
,
Mar 24 2017
,
Mar 25 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8d7d51737a0212e56a4e41d3800187ba0820ba17 commit 8d7d51737a0212e56a4e41d3800187ba0820ba17 Author: Matthias Kaehlcke <mka@chromium.org> Date: Mon Mar 27 16:35:23 2017 power: Don't install autosuspend rules on 'embedded' devices CL:434906 installs static udev rules to configure autosuspend, which was previously handled by laptop-mode-tools. The rules are installed on all targets, however laptop-mode-tools is only used on non-'embedded' devices. Expanding autosuspend unintendedly to all device has caused at least one problem (b:36470502). Limit the installation of the autosuspend rules to non-'embedded' devices to return to the previous situation. BUG= chromium:704330 , b:36470502 TEST=emerge-whirlwind power_manager ls /build/gru/lib/udev/rules.d/99-autosuspend.rules => No such file or directory emerge-gru power_manager ls /build/gru/lib/udev/rules.d/99-autosuspend.rules => /build/gru/lib/udev/rules.d/99-autosuspend.rules Change-Id: Ia87d07746f2457884c8e6641ab4ad93b780c6fdd Reviewed-on: https://chromium-review.googlesource.com/458557 Commit-Ready: Matthias Kaehlcke <mka@chromium.org> Tested-by: Matthias Kaehlcke <mka@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> (cherry picked from commit 25e3b5c4dd326cff1ebf384e4f8e9d86a802a3e1) Reviewed-on: https://chromium-review.googlesource.com/458985 Reviewed-by: Matthias Kaehlcke <mka@chromium.org> Commit-Queue: Matthias Kaehlcke <mka@chromium.org> [modify] https://crrev.com/8d7d51737a0212e56a4e41d3800187ba0820ba17/chromeos-base/power_manager/power_manager-9999.ebuild
,
Mar 27 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 23 2017