New issue
Advanced search Search tips

Issue 704313 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

third_party/libvpx/generate_gni.sh errors on macOS Sierra

Project Member Reported by jianj@chromium.org, Mar 22 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)
Latest code on macOS Sierra 10.12.3

What steps will reproduce the problem?
(1) Checkout latest chromium code
(2) cd third_party/libvpx
(3) ./generate_gni.sh --enable-vp9-highbitdepth

What is the expected result?
The script should run without errors.

What happens instead?

Create temporary directory.
Generate config files.
Remove temporary directory.
Lint libvpx configuration.
Error: Configuration mismatch for .seARCH_ARM.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seARCH_MIPS.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seARCH_X86.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seARCH_X86_64.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seCONFIG_BETTER_HW_COMPATIBILITY.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seCONFIG_BIG_ENDIAN.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm


Error: Configuration mismatch for .seCONFIG_CODEC_SRCS.
Header file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.h

Assembly file: /Users/jianj/Codes/chromium_test/src/third_party/libvpx/source/config/ios/arm-neon/vpx_config.asm

............(Very long list)

Please use labels and text to provide additional information.

Comment out "ios" related lines will solve this issue but that's not a solution.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by jianj@chromium.org, Mar 22 2017

Summary: third_party/libvpx/generate_gni.sh errors on macOS Sierra (was: ./generate_gni.sh errors on macOS Sierra)

Comment 2 by shrike@chromium.org, Mar 25 2017

Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Fix uploaded:
https://codereview.chromium.org/2767143004/

Waiting on Tom to rubber-stamp it, unless any other committer wants to take a peek?
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c8b47a34d4ad141c14fc83e644e3c53edd5b37c

commit 8c8b47a34d4ad141c14fc83e644e3c53edd5b37c
Author: johannkoenig <johannkoenig@google.com>
Date: Tue Mar 28 14:35:38 2017

libvpx: use bsd-compatible sed expressions

Use [[:space:]] instead of \s for whitespace matching

On OS X, the bsd sed does not support \s

BUG= chromium:704313 

Review-Url: https://codereview.chromium.org/2767143004
Cr-Commit-Position: refs/heads/master@{#460102}

[modify] https://crrev.com/8c8b47a34d4ad141c14fc83e644e3c53edd5b37c/third_party/libvpx/generate_gni.sh
[modify] https://crrev.com/8c8b47a34d4ad141c14fc83e644e3c53edd5b37c/third_party/libvpx/lint_config.sh

Status: Fixed (was: Started)

Sign in to add a comment