New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704311 link

Starred by 1 user
Status: Fixed
Owner:
█ chili@chromium.org
Last visit 22 days ago
Closed: Mar 2017
Cc:
dewittj@chromium.org
█ dim...@chromium.org
fgor...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Download UI Adapter crashloop

Project Member Reported by chili@chromium.org, Mar 22 2017 
Build from ToT sometime last week (week of March 13)

This appears to be a randomly occurring issue:

1. queue 10-15 pages in the request queue when offline
2. turn on wifi
3. wait while pages download
4. if one of the pages seem to hang (10+ minutes), click on the notification

This may be a disconnect from the background loader (ptrs invalidated too often?) to the request coordinator. The actual failure is caused by a dcheck making sure there isn't a request with the same ID as an offline page.
downloaduiadapter.foo
351 KB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ad9a9d95cdf1ca2e7ffafb03a6e7ffdd74106d

commit 69ad9a9d95cdf1ca2e7ffafb03a6e7ffdd74106d
Author: chili <chili@chromium.org>
Date: Thu Mar 23 22:41:26 2017

[Offline pages] Check errors and invalidate pointers only for mainframe for navigation

BUG= 704311 

Review-Url: https://codereview.chromium.org/2764373004
Cr-Commit-Position: refs/heads/master@{#459263}

[modify] https://crrev.com/69ad9a9d95cdf1ca2e7ffafb03a6e7ffdd74106d/chrome/browser/android/offline_pages/background_loader_offliner.cc

Comment 2 by chili@chromium.org, Mar 24 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 24 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1d532610401b82b715e6ccd83e114d15363e91f

commit e1d532610401b82b715e6ccd83e114d15363e91f
Author: Filip Gorski <fgorski@chromium.org>
Date: Fri Mar 24 19:38:28 2017

[Offline pages] Check errors and invalidate pointers only for mainframe for navigation

BUG= 704311 

Review-Url: https://codereview.chromium.org/2764373004
Cr-Commit-Position: refs/heads/master@{#459263}
(cherry picked from commit 69ad9a9d95cdf1ca2e7ffafb03a6e7ffdd74106d)

Review-Url: https://codereview.chromium.org/2771933004 .
Cr-Commit-Position: refs/branch-heads/3029@{#412}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/e1d532610401b82b715e6ccd83e114d15363e91f/chrome/browser/android/offline_pages/background_loader_offliner.cc

Comment 5 by chili@chromium.org, Mar 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment