New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704302 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Remove TestMediaStreamVideoRenderer usage from LayoutTests

Project Member Reported by emir...@chromium.org, Mar 22 2017

Issue description

When running layout tests, there isn't a real video renderer for media streams but a TestMediaStreamVideoRenderer implementation instead. This implementation generates a stream of white frames and sends them in certain intervals. Video content aren't the real content and video events are also useless. We came across to this issue again on https://codereview.chromium.org/2768683002/#msg16.

Do you know why this is implemented? AFAICT, plugging WebMediaPlayerMS instead works in Linux and outputs real video content.
 
Labels: -Type-Feature Type-Task
Status: Unconfirmed (was: Available)
Note that I wanted to open this topic as a point of discussion. I am still not sure what are the caveats of this change. See https://codereview.chromium.org/2780353003/#msg13.

guidou@ do you know why we have this? Feel free to cc anyone who might know about it as well.
Cc: perkj@chromium.org
emircan@: I don't know anything about it. Perhaps perkj@ knows something about it?

Comment 3 by tommi@chromium.org, Apr 26 2017

Owner: emir...@chromium.org
Status: Assigned (was: Unconfirmed)
emircan - I'm assigning back to you since it's not clear who's the right person. I dug around and found this CL: https://codereview.chromium.org/2005053006
Which is on the blamelist for 'class TestMediaStreamVideoRenderer' and was reviewed by you (it's a naming cleanup CL so I figured the reviewer would be a more appropriate owner than the author).
tommi@ sure I can take the bug. I am still not sure about why this class is there though. Currently, webkit tests aren't covering most of the code because of this. It goes back to below CL where both people left, so I am trying to find if anybody else knows about it. 
https://chromiumcodereview.appspot.com/10918052

Sign in to add a comment