New issue
Advanced search Search tips

Issue 704295 link

Starred by 1 user
Status: Fixed
Owner:
lambroslambrou@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

WebView deprecation warnings when building remoting_apk

Project Member Reported by lambroslambrou@chromium.org, Mar 22 2017 
Building remoting_apk gives these warnings:

[5977/6045] ACTION //remoting/android:remoting_android_client_java__compile_java__javac(//build/toolchain/android:android_arm)
../../remoting/android/java/src/org/chromium/chromoting/help/CreditsActivity.java:40: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
            public boolean shouldOverrideUrlLoading(WebView view, String url) {
                           ^
../../remoting/android/java/src/org/chromium/chromoting/help/HelpActivity.java:90: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
            public boolean shouldOverrideUrlLoading(WebView view, String url) {
                           ^
2 warnings
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c378901b8de15db486c3cba91696504fc99e353c

commit c378901b8de15db486c3cba91696504fc99e353c
Author: lambroslambrou <lambroslambrou@chromium.org>
Date: Thu Mar 23 17:51:20 2017

[remoting android] Fix WebView deprecation warnings

One of the WebViewClient interface methods is deprecated, but it must
be kept around to work on older Android versions. This CL implements
both older and newer methods, with appropriate annotations to suppress
build warnings.

BUG= 704295 

Review-Url: https://codereview.chromium.org/2769813003
Cr-Commit-Position: refs/heads/master@{#459134}

[modify] https://crrev.com/c378901b8de15db486c3cba91696504fc99e353c/remoting/android/java/src/org/chromium/chromoting/help/CreditsActivity.java
[modify] https://crrev.com/c378901b8de15db486c3cba91696504fc99e353c/remoting/android/java/src/org/chromium/chromoting/help/HelpActivity.java

Comment 2 by lambroslambrou@chromium.org, Mar 23 2017

Status: Fixed (was: Started)
►

Sign in to add a comment