New issue
Advanced search Search tips

Issue 704287 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 704285

Blocking:
issue 706860
issue 759163



Sign in to add a comment

Write Ash overdraw regression tests

Project Member Reported by rjkroege@chromium.org, Mar 22 2017

Issue description

To compare Cash, Mushrome, Mash, write a series of tests that:

1. run CrOS Chrome on a bot using https://crbug.com/704285
2. do some UX actions and measure the overdraw

User actions considered desirable:

* close a Chrome window to the ash shelf a Chrome window of known size
* maximize a Chrome window from a known size to full screen
* resize a Chrome window


 

Comment 1 by sadrul@chromium.org, Mar 23 2017

Description: Show this description
Components: Internals>MUS
Labels: mustash-2 Proj-Mustash
Blocking: 706860

Comment 4 by sky@chromium.org, Jun 8 2017

Blocking: 731255
Cc: jonr...@chromium.org

Comment 6 by sadrul@chromium.org, Aug 22 2017

Blockedon: 672929
Cc: rjkroege@chromium.org varkha@chromium.org
Owner: yiyix@chromium.org
Status: Assigned (was: Available)
Tentatively assigning to yiyix@

yiyix@: Since you are working on draw occlusion on  issue 672929 , you will have most context on what kind of tests in ash would be best for measuring overdraw (and showing improvement as a result of draw occlusion).

Comment 7 by sadrul@chromium.org, Aug 25 2017

Blockedon: -672929

Comment 8 by sadrul@chromium.org, Aug 25 2017

Blocking: 759163
Blocking: -731255
This should not block mus (or mushrome). This is more relevant for mustash.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6f9d70b00b8a7594c64d9a8d8f25151eb503abd

commit d6f9d70b00b8a7594c64d9a8d8f25151eb503abd
Author: yiyix <yiyix@chromium.org>
Date: Thu Nov 30 04:53:39 2017

Perf analysis for Display::RemoveDrawQuads

Add tests to evaluate RemoveOverdrawQuads performance, ref:
https://docs.google.com/document/d/1gM4h1ca2jDWdXbYa9yjC53m0sJzaT9skqbPGnfDsdyI/edit

Sample Result:
*RESULT RemoveOverdrawDraws Iterates patrially overlap
SharedQuadStates: : 10 sqs with 100 quads= 63781.3125 runs/s
*RESULT RemoveOverdrawDraws Iterates patrially overlap
SharedQuadStates: : 2 sqs with 4 quads= 49180.43359375 runs/s
*RESULT RemoveOverdrawDraws Iterates patrially overlap
SharedQuadStates: : 10 sqs with 100 quads= 10247.52734375 runs/s


Bug: 704287
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I57c225d78aef0a6779330fff77943ee26950113f
Reviewed-on: https://chromium-review.googlesource.com/769927
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520444}
[modify] https://crrev.com/d6f9d70b00b8a7594c64d9a8d8f25151eb503abd/components/viz/service/BUILD.gn
[add] https://crrev.com/d6f9d70b00b8a7594c64d9a8d8f25151eb503abd/components/viz/service/display/display_perftest.cc

Components: -Internals>MUS Internals>Services>WindowService
Labels: -Proj-Mustash Proj-Mash-SingleProcess
Yi, are you still working on this? We have a general performance bug filed for mash work here: 681067. I believe Sadrul has created some tests as well.
Labels: -Proj-Mash-SingleProcess Proj-Mash-MultiProcess OS-Chrome
I'm punting this. I will ensure there is at least one test that measures interactive window resize.

Sign in to add a comment