Issue metadata
Sign in to add a comment
|
Chrome OS: Alt+Search sometimes pops up the search dialog |
||||||||||||||||||||||
Issue descriptionChrome Version : 59.0.3041.0 OS Version: 9375.0.0 test What steps will reproduce the problem? 1. Press Alt 2. Press Search 3. Release Alt 4. Release Search What is the expected result? At step #3 or #4, CapsLock is toggled. What happens instead of that? At step #3, CapsLock is toggled which is good, *and* at step #4, the search dialog also pops up.
,
Mar 22 2017
,
Mar 22 2017
Note: this DOES reproduce even when Search and Ctrl are swapped.
,
Mar 23 2017
I think a lot of our problems will be fixed if we stop storing repeat events in the accelerator history [https://cs.chromium.org/chromium/src/ui/wm/core/accelerator_filter.cc?q=AcceleratorFilter+package:%5Echromium$&l=43].
,
Mar 23 2017
It's about time to fix this accelerator history mess. I have a design for this.
,
Apr 4 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/820f3f7b4622520426a295d93852701caa204a2f commit 820f3f7b4622520426a295d93852701caa204a2f Author: afakhry <afakhry@chromium.org> Date: Tue Apr 18 19:49:36 2017 Fix accelerator history tracking Track the currently pressed keys so that we don't mistakenly store an already pressed key as a new keypress after another key has been released. BUG= 704280 TEST=covered by tests. Review-Url: https://codereview.chromium.org/2792413002 Cr-Commit-Position: refs/heads/master@{#465337} [modify] https://crrev.com/820f3f7b4622520426a295d93852701caa204a2f/ui/base/BUILD.gn [modify] https://crrev.com/820f3f7b4622520426a295d93852701caa204a2f/ui/base/accelerators/accelerator_history.cc [modify] https://crrev.com/820f3f7b4622520426a295d93852701caa204a2f/ui/base/accelerators/accelerator_history.h [add] https://crrev.com/820f3f7b4622520426a295d93852701caa204a2f/ui/base/accelerators/accelerator_history_unittest.cc
,
Apr 19 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by yusukes@chromium.org
, Mar 22 2017