Issue metadata
Sign in to add a comment
|
Tab capture always starts on max resolution and then scales down |
||||||||||||||||||||||
Issue descriptionChrome Version: 57 OS: all Forked off from https://bugs.chromium.org/p/chromium/issues/detail?id=700955. When starting a tab capture session using chooseDesktopMedia and getUserMedia you always get the max resolution (from constraints) for the first 2 seconds, and then it scales down to the native tab resolution. This isn't strictly violating the spec, but it's undesirable since you often end up with an oversampled imaged with padding added and have to deal with resolution changes.
,
May 4 2017
miu@ are you working on this at the moment?
,
May 4 2017
anatolid: No. Feel free to take this if you want. I vaguely recall this issue getting fixed, though. We should re-check. Pretty simple, just turn on verbose logging (--vmodule=video_capture_oracle=2), and look for this log line: https://cs.chromium.org/chromium/src/media/capture/content/video_capture_oracle.cc?rcl=d01fb51d1a9ba850c92f525dc31187ef79a2586c&l=398
,
May 5 2017
Back at my desk, just tried this on a recent trunk build: Still an issue. Actually, I'll whip-up a quick change to address this. I think we can just make sure the size is set before, instead of just after, the first frame is captured from a new RenderWidgetHostView target.
,
May 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bebdfb5fde6a56eb40c7f2efc7bc0cbbcecdc41e commit bebdfb5fde6a56eb40c7f2efc7bc0cbbcecdc41e Author: miu <miu@chromium.org> Date: Sat May 06 18:53:15 2017 Tab Capture: Set size before changing target RWHV Fixes a performance issue where tab capture always starts out at the maximum configured resolution, regardless of the source size. This change ensures the source size updates the capture size before the first frame is ever captured. BUG= 704277 Review-Url: https://codereview.chromium.org/2859223005 Cr-Commit-Position: refs/heads/master@{#469851} [modify] https://crrev.com/bebdfb5fde6a56eb40c7f2efc7bc0cbbcecdc41e/content/browser/media/capture/web_contents_tracker.cc
,
May 8 2017
,
May 9 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by m...@chromium.org
, Mar 22 2017