New issue
Advanced search Search tips

Issue 704260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 703708



Sign in to add a comment

Provision devices/devil unable to turn (Kitkat|Lollipip) tablet screens on

Project Member Reported by bpastene@chromium.org, Mar 22 2017

Issue description

The following builders have been failing a wide range of suites for the past few days:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester
https://uberchromegw.corp.google.com/i/chromium.android/builders/KitKat%20Tablet%20Tester

Many of the failing tests complain with:
I  165.199s run_tests_on_device(05984fda)    java.lang.AssertionError: Many tests will fail if the screen is not on.
I  165.199s run_tests_on_device(05984fda)    	at org.junit.Assert.fail(Assert.java:88)
I  165.199s run_tests_on_device(05984fda)    	at org.junit.Assert.assertTrue(Assert.java:41)
I  165.199s run_tests_on_device(05984fda)    	at org.chromium.content_shell_apk.ContentShellTestCommon.assertScreenIsOn(ContentShellTestCommon.java:67)
I  165.200s run_tests_on_device(05984fda)    	at org.chromium.content_shell_apk.ContentShellTestBase.setUp(ContentShellTestBase.java:47)
I  165.200s run_tests_on_device(05984fda)    	at org.chromium.content.browser.ContentViewCoreSelectionTest.setUp(ContentViewCoreSelectionTest.java:48)
I  165.200s run_tests_on_device(05984fda)    	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
I  165.200s run_tests_on_device(05984fda)    	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
I  165.200s run_tests_on_device(05984fda)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I  165.200s run_tests_on_device(05984fda)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I  165.200s run_tests_on_device(05984fda)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I  165.200s run_tests_on_device(05984fda)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)


SSH'ing on a bot in the middle of a test confirms that a few of the devices have their screen off:
chrome-bot@build42-b1:(Linux 14.04):~$ /b/c/b/KitKat_Tablet_Tester/src/third_party/android_tools/sdk/platform-tools/adb devices | awk '/device$/ {system("/b/c/b/KitKat_Tablet_Tester/src/third_party/android_tools/sdk/platform-tools/adb -s "$1" shell dumpsys input_method")}' | grep mScreenOn
  mSystemReady=true mScreenOn=false
  mSystemReady=true mScreenOn=false
  mSystemReady=true mScreenOn=false
  mSystemReady=true mScreenOn=false
  mSystemReady=true mScreenOn=true
  mSystemReady=true mScreenOn=true
  mSystemReady=true mScreenOn=true


The first build that failed contains this catapult roll which contains a number of devil CLs:
https://codereview.chromium.org/2761833002

Assigning to perezju@ who authored the devil changes contained in that catapult roll. It seems something in there is preventing tablet screens from turning on?
 
Cc: -jbudorick@chromium.org perezju@chromium.org
Owner: jbudorick@chromium.org
Status: Started (was: Untriaged)
Looks like the typo monster:

I  127.296s TimeoutThread-1-for-ProvisionDevice(05837e65)  [host]> /b/c/b/KitKat_Tablet_Tester/src/third_party/android_tools/sdk/platform-tools/adb -s 05837e65 shell '( content instert --uri content://settings/global --bind name:s:stay_on_while_plugged_in --bind value:i:3 );echo %$?'

https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil/android/settings.py?rcl=f410d46fe0f63a221c8099698bb798a245f2a9c0&l=176


Locally, when running `content instert ...`, I get:

adb shell
... settings/global --bind name:s:stay_on_while_plugged_in --bind value:i:3       <
usage: adb shell content [subcommand] [options]

usage: adb shell content insert --uri <URI> [--user <USER_ID>] --bind <BINDING> [--bind <BINDING>...]
  <URI> a content provider URI.
  <BINDING> binds a typed value to a column and is formatted:
  <COLUMN_NAME>:<TYPE>:<COLUMN_VALUE> where:
  <TYPE> specifies data type such as:
  b - boolean, s - string, i - integer, l - long, f - float, d - double
  Note: Omit the value for passing an empty string, e.g column:s:
  Example:
  # Add "new_setting" secure setting with value "new_value".
  adb shell content insert --uri content://settings/secure --bind name:s:new_setting --bind value:s:new_value

usage: adb shell content update --uri <URI> [--user <USER_ID>] [--where <WHERE>]
  <WHERE> is a SQL style where clause in quotes (You have to escape single quotes - see example below).
  Example:
  # Change "new_setting" secure setting to "newer_value".
  adb shell content update --uri content://settings/secure --bind value:s:newer_value --where "name='new_setting'"

usage: adb shell content delete --uri <URI> [--user <USER_ID>] --bind <BINDING> [--bind <BINDING>...] [--where <WHERE>]
  Example:
  # Remove "new_setting" secure setting.
  adb shell content delete --uri content://settings/secure --where "name='new_setting'"

usage: adb shell content query --uri <URI> [--user <USER_ID>] [--projection <PROJECTION>] [--where <WHERE>] [--sort <SORT_ORDER>]
  <PROJECTION> is a list of colon separated column names and is formatted:
  <COLUMN_NAME>[:<COLUMN_NAME>...]
  <SORT_ORDER> is the order in which rows in the result should be sorted.
  Example:
  # Select "name" and "value" columns from secure settings where "name" is equal to "new_setting" and sort the result by name in ascending order.
  adb shell content query --uri content://settings/secure --projection name:value --where "name='new_setting'" --sort "name ASC"

usage: adb shell content call --uri <URI> --method <METHOD> [--arg <ARG>]
       [--extra <BINDING> ...]
  <METHOD> is the name of a provider-defined method
  <ARG> is an optional string argument
  <BINDING> is like --bind above, typed data of the form <KEY>:{b,s,i,l,f,d}:<VAL>


[ERROR] Unsupported operation: instert
shell@mako:/ $ echo $?
0
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f56a486070ad1881202f894e8296918f287fb5

commit a7f56a486070ad1881202f894e8296918f287fb5
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Mar 23 00:39:41 2017

Roll src/third_party/catapult/ b3c85690c..2038d744a (3 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b3c85690c061..2038d744a2d8

$ git log b3c85690c..2038d744a --date=short --no-merges --format='%ad %ae %s'
2017-03-22 jbudorick [devil] instert -> insert in devil.android.settings.
2017-03-22 dtu Make deployment work when there's no local master branch.
2017-03-22 simonhatch Dashboard - Fix LogBisectResult not being called with valid job.

Created with:
  roll-dep src/third_party/catapult
BUG= 704260 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2773543003
Cr-Commit-Position: refs/heads/master@{#458957}

[modify] https://crrev.com/a7f56a486070ad1881202f894e8296918f287fb5/DEPS

Comment 3 by joh...@chromium.org, Mar 23 2017

Blocking: 703708
This fixed  issue 703708  :)
Status: Fixed (was: Started)

Sign in to add a comment