New issue
Advanced search Search tips

Issue 704243 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

paint/invalidation/focus-ring-on-continuation-move.html is actually failing

Project Member Reported by wangxianzhu@chromium.org, Mar 22 2017

Issue description

Both of the test and the ref encounter  bug 703403 , hiding the real failure.

https://codereview.chromium.org/2765763002/ is to fix this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/437d0b9a1fbd7345b234e54e09716f501c37ccb8

commit 437d0b9a1fbd7345b234e54e09716f501c37ccb8
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed Mar 22 22:19:01 2017

Fix inline focus ring paint invalidation on continuation change

An inline element's focus ring encloses its block and inline
continuations. The previous method handled invalidation of
display item client only, not rectangles covering the changed
inlines.

Now call setMayNeedPaintInvalidation() on the inline whose block
continuations are marked needsPaintOffsetAndVisualRectUpdate().

Also noticed a focus ring painting bug ( crbug.com/703403 ) and added
a test case. Will fix later.

BUG= 704243 ,  703403 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2765763002
Cr-Commit-Position: refs/heads/master@{#458895}

[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/inline/focus-ring-under-absolute-with-relative-continuation-expected.html
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/inline/focus-ring-under-absolute-with-relative-continuation.html
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/invalidation/focus-ring-on-continuation-move-expected.html
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/invalidation/focus-ring-on-continuation-move-expected.txt
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/invalidation/focus-ring-on-continuation-move.html
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/invalidation/focus-ring-on-inline-continuation-move-expected.html
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/paint/invalidation/focus-ring-on-inline-continuation-move.html
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/focus-ring-on-continuation-move-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/focus-ring-on-continuation-move-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/focus-enable-continuations-expected.txt
[add] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/focus-ring-on-inline-continuation-move-expected.txt
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/437d0b9a1fbd7345b234e54e09716f501c37ccb8/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp

Status: Fixed (was: Started)

Sign in to add a comment