New issue
Advanced search Search tips

Issue 704230 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

convert PageCycler to JUnit4

Project Member Reported by timvolod...@chromium.org, Mar 22 2017

Issue description

any plans on converting android_webview/tools/system_webview_shell/page_cycler

to JUnit4 like the layout tests were done?

 
Status: Available (was: Untriaged)
also getting some lint warnings:

//android_webview/tools/system_webview_s...pile_java__javac(//build/toolchain/android:android_arm64)
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/PageCyclerTest.java:8: warning: [deprecation] ActivityInstrumentationTestCase2 in android.test has been deprecated
import android.test.ActivityInstrumentationTestCase2;
                   ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/WebViewPageCyclerTestRunner.java:7: warning: [deprecation] AndroidTestRunner in android.test has been deprecated
import android.test.AndroidTestRunner;
                   ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/WebViewPageCyclerTestRunner.java:8: warning: [deprecation] InstrumentationTestRunner in android.test has been deprecated
import android.test.InstrumentationTestRunner;
                   ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/PageCyclerTest.java:25: warning: [deprecation] ActivityInstrumentationTestCase2 in android.test has been deprecated
        extends ActivityInstrumentationTestCase2<PageCyclerTestActivity> {
                ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/PageCyclerTest.java:115: warning: [deprecation] onReceivedError(WebView,int,String,String) in WebViewClient has been deprecated
        public void onReceivedError(WebView webview, int code, String description,
                    ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/WebViewPageCyclerTestRunner.java:15: warning: [deprecation] InstrumentationTestRunner in android.test has been deprecated
public class WebViewPageCyclerTestRunner extends InstrumentationTestRunner {
                                                 ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/WebViewPageCyclerTestRunner.java:18: warning: [deprecation] AndroidTestRunner in android.test has been deprecated
    protected AndroidTestRunner getAndroidTestRunner() {
              ^
../../android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/WebViewPageCyclerTestRunner.java:19: warning: [deprecation] AndroidTestRunner in android.test has been deprecated
        AndroidTestRunner runner = super.getAndroidTestRunner();
        ^
8 warnings

Cc: yolandyan@chromium.org
+yolandyan@ : as the original author (if I remember correctly)
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 28 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -yolandyan@chromium.org
Components: Test Mobile>WebView
Status: Available (was: Untriaged)

Sign in to add a comment