New issue
Advanced search Search tips

Issue 704224 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Google Chrome Framework exposes some symbols that it shouldn’t

Project Member Reported by mark@chromium.org, Mar 22 2017

Issue description

mark@garbage bash$ nm -nU '/Applications/Google Chrome Canary.app/Contents/Versions/59.0.3048.0/Google Chrome Framework.framework/Google Chrome Framework'
0000000000002100 T _ChromeAppModeStart_v4
0000000000003030 T _KeychainReauthorizeIfNeededAtUpdate
0000000000003070 T _ChromeMain
0000000006989758 S _CIDetectorTypeQRCode
0000000006989760 S _NSUserActivityTypeBrowsingWeb
0000000006989768 S _NSAppearanceNameVibrantDark

The three text symbols are fine. There are reasons for them to show up.

The three data symbols are not. We don’t need to expose them from our framework.

These are coming from sdk_forward_declarations.{h,mm}:

https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce49485a746b379/base/mac/sdk_forward_declarations.h#71
https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce49485a746b379/base/mac/sdk_forward_declarations.mm

Providing our own declarations and definitions of these for cases where they’re missing from the SDK or missing at runtime is fine. But let’s not expose them from our framework.
 

Sign in to add a comment