New issue
Advanced search Search tips

Issue 704219 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Set isTrusted of coalesced events to true when the original event is trusted

Project Member Reported by nzolghadr@chromium.org, Mar 22 2017

Issue description

Right now we leave the isTrusted flag of the coalesced events as false. However, spec suggests that we should still set the isTrusted flag to true when the event is initiated by the browser.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/779888ee1eba464ede92e539999ebb772afaa0ae

commit 779888ee1eba464ede92e539999ebb772afaa0ae
Author: nzolghadr <nzolghadr@chromium.org>
Date: Fri Mar 31 17:10:02 2017

Set trusted flag of coalesced events at creation

Set trusted, bubbles, and cancelable flags of
the coalesced events to true at the creation time.
Note that we didn't set it along with the original
event to avoid unnecessary traverse of all the
coalesced events for redispatching.
This CL also adds a wpt test and its automation for
coalesced events.
Note that the test doesn't quite pass as we don't
run them with compositor thread enabled.

BUG= 704219 

Review-Url: https://codereview.chromium.org/2772443006
Cr-Commit-Position: refs/heads/master@{#461155}

[modify] https://crrev.com/779888ee1eba464ede92e539999ebb772afaa0ae/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/779888ee1eba464ede92e539999ebb772afaa0ae/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual-expected.txt
[add] https://crrev.com/779888ee1eba464ede92e539999ebb772afaa0ae/third_party/WebKit/LayoutTests/external/wpt/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html
[add] https://crrev.com/779888ee1eba464ede92e539999ebb772afaa0ae/third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/extension/pointerevent_coalesced_events_attributes-manual-automation.js
[modify] https://crrev.com/779888ee1eba464ede92e539999ebb772afaa0ae/third_party/WebKit/Source/core/events/PointerEventFactory.cpp

Status: Fixed (was: Started)

Sign in to add a comment