Verify that an APK is signed in the comment by checking the contents of the APK against a specific public elliptical curve key.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/45e1d14b15dd10b4d08481d1797255c19558c824 commit 45e1d14b15dd10b4d08481d1797255c19558c824 Author: scottkirkwood <scottkirkwood@chromium.org> Date: Thu Apr 13 22:39:22 2017 Commment signed webapks working with verification. * In my test it took 11ms to verify the signature. * Takes about 1ms to check if it's a webapk at all (vs 0.9ms previously). BUG= 704213 Review-Url: https://codereview.chromium.org/2772483002 Cr-Commit-Position: refs/heads/master@{#464579} [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHostSignature.java [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/webapk/libs/client/BUILD.gn [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkVerifySignatureTest.java [modify] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/bad-sig.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/bad-utf8-fname.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/empty.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/example.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/extra-len-too-large.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/fcomment-too-large.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/java-example.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/no-cd.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/no-comment.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/no-eocd.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/no-lfh.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/not-an.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/public.der [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/too-many-metainf.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/truncated.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/zeros-at-end.apk [add] https://crrev.com/45e1d14b15dd10b4d08481d1797255c19558c824/chrome/test/data/webapks/zeros.apk
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e57373452b02aabe667d9027c3e2fad6ac6562 commit d3e57373452b02aabe667d9027c3e2fad6ac6562 Author: yfriedman <yfriedman@chromium.org> Date: Thu May 25 17:01:01 2017 Remove command-line restriction for comment-signed WebApks. Allows any WebApk signed correctly with comment-signing to receive full-screen treatment BUG= 704213 Review-Url: https://codereview.chromium.org/2903743003 Cr-Commit-Position: refs/heads/master@{#474679} [modify] https://crrev.com/d3e57373452b02aabe667d9027c3e2fad6ac6562/chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java [modify] https://crrev.com/d3e57373452b02aabe667d9027c3e2fad6ac6562/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java [modify] https://crrev.com/d3e57373452b02aabe667d9027c3e2fad6ac6562/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java [modify] https://crrev.com/d3e57373452b02aabe667d9027c3e2fad6ac6562/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkValidatorTest.java [modify] https://crrev.com/d3e57373452b02aabe667d9027c3e2fad6ac6562/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
Comment 1 by bugdroid1@chromium.org
, Apr 13 2017