New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704197 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----

Blocked on:
issue 679768

Blocking:
issue 664505
issue 710524



Sign in to add a comment

Re-enable stories failing due to large trace size

Project Member Reported by ashleymarie@chromium.org, Mar 22 2017

Issue description

v8.runtimestats.browsing_desktop on ATI GPU on Windows on Windows-2008ServerR2-SP1 failing on chromium.perf/Win 7 ATI GPU Perf

Builders failed on: 
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf

Succeeded at r458055
Failed at r458056:r458172

https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FWin_7_ATI_GPU_Perf%2F511%2F%2B%2Frecipes%2Fsteps%2Fv8.runtimestats.browsing_desktop_on_ATI_GPU_on_Windows_on_Windows-2008ServerR2-SP1%2F0%2Fstdout

[ RUN      ] c:\b\s\w\itrbyecm\tmp4mvkh9.html
TraceImportError: Invalid string length
    at Array.join (native)
    at Object.f [as string] (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:20494)
    at Object.c.transformTo (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:22247)
    at Object.c.transformTo (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:6414)
    at Function.GzipImporter.transformToString (/tracing/extras/importer/gzip_importer.html:141:26)
    at Function.GzipImporter.inflateGzipData_ (/tracing/extras/importer/gzip_importer.html:116:31)
    at GzipImporter.extractSubtraces (/tracing/extras/importer/gzip_importer.html:177:36)
    at Import.createImports (/tracing/importer/import.html:139:40)
    at Task.run (/tracing/base/task.html:71:21)
    at Function.Task.RunSynchronously (/tracing/base/task.html:152:25)
[  FAILED  ] c:\b\s\w\itrbyecm\tmp4mvkh9.html (12405 ms)
Traceback (most recent call last):
  File "c:\b\s\w\irmfoql9\third_party\catapult\telemetry\telemetry\value\failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: TraceImportError: Invalid string length
    at Array.join (native)
    at Object.f [as string] (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:20494)
    at Object.c.transformTo (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:22247)
    at Object.c.transformTo (c:\b\s\w\irmfoql9\third_party\catapult\tracing\third_party\jszip/jszip.min.js:12:6414)
    at Function.GzipImporter.transformToString (/tracing/extras/importer/gzip_importer.html:141:26)
    at Function.GzipImporter.inflateGzipData_ (/tracing/extras/importer/gzip_importer.html:116:31)
    at GzipImporter.extractSubtraces (/tracing/extras/importer/gzip_importer.html:177:36)
    at Import.createImports (/tracing/importer/import.html:139:40)
    at Task.run (/tracing/base/task.html:71:21)
    at Function.Task.RunSynchronously (/tracing/base/task.html:152:25)

[  FAILED  ] browse:media:imgur@{'case': 'browse', 'group': 'media'} (235527 ms)


 
Cc: mythria@chromium.org
It is consistently failing on the imgur page. Also the v8.browsing_desktop benchmark which uses the same page set fails on that page. Systemhealth benchmarks work on that page though. 
Cc: hablich@chromium.org
v8.runtimestats.browsing_desktop_classic is also failing with the same error on that imgur page
Cc: nednguyen@chromium.org
Cc: nedngu...@google.com
Stacktrace looks like it is catapult/telemetry related.
Cc: altimin@chromium.org
Owner: mythria@chromium.org
mythria: bug 702215 stopped us from seeing that there are also problems on Mac due to imgur page. Do you think you could take this bug and disable the imgur page?

cc-ing altimin, today's perfbot sheriff, as FYI.

Details on Mac imgur failures look the same:
https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Pro_10.11_Perf%2F754%2F%2B%2Frecipes%2Fsteps%2Fv8.runtimestats.browsing_desktop_on_ATI_GPU_on_Mac_on_Mac-10.11%2F0%2Fstdout
[ RUN      ] /b/s/w/itz5Nmdb/tmpXPrpYl.html
TraceImportError: Invalid string length
    at Array.join (native)
    at Object.f [as string] (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:20494)
    at Object.c.transformTo (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:22247)
    at Object.c.transformTo (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:6414)
    at Function.GzipImporter.transformToString (/tracing/extras/importer/gzip_importer.html:141:26)
    at Function.GzipImporter.inflateGzipData_ (/tracing/extras/importer/gzip_importer.html:116:31)
    at GzipImporter.extractSubtraces (/tracing/extras/importer/gzip_importer.html:177:36)
    at addImportStage (/tracing/importer/import.html:158:40)
    at Task.run (/tracing/base/task.html:79:21)
    at Function.Task.RunSynchronously (/tracing/base/task.html:160:25)
[  FAILED  ] /b/s/w/itz5Nmdb/tmpXPrpYl.html (11246 ms)
Traceback (most recent call last):
  File "/b/s/w/ir0LhSFo/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: TraceImportError: Invalid string length
    at Array.join (native)
    at Object.f [as string] (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:20494)
    at Object.c.transformTo (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:22247)
    at Object.c.transformTo (/b/s/w/ir0LhSFo/third_party/catapult/tracing/third_party/jszip/jszip.min.js:12:6414)
    at Function.GzipImporter.transformToString (/tracing/extras/importer/gzip_importer.html:141:26)
    at Function.GzipImporter.inflateGzipData_ (/tracing/extras/importer/gzip_importer.html:116:31)
    at GzipImporter.extractSubtraces (/tracing/extras/importer/gzip_importer.html:177:36)
    at addImportStage (/tracing/importer/import.html:158:40)
    at Task.run (/tracing/base/task.html:79:21)
    at Function.Task.RunSynchronously (/tracing/base/task.html:160:25)

[  FAILED  ] browse:media:imgur@{'case': 'browse', 'group': 'media'} (215501 ms)
Cc: chiniforooshan@chromium.org charliea@chromium.org
+chiniforooshan, charliea: #6 looks like a trace size error
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce15846003ee139aa4627fb6357da7c80affa4a2

commit ce15846003ee139aa4627fb6357da7c80affa4a2
Author: Mythri Alle <mythria@chromium.org>
Date: Fri Mar 24 19:33:54 2017

Disable imgur page from system health's browse page set.

Imgur page fails on windows and mac platforms.

Bug:704197

Change-Id: Ia54508f51419776a1f6e72c09ef292c7f95060dc
Reviewed-on: https://chromium-review.googlesource.com/459557
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#459521}
[modify] https://crrev.com/ce15846003ee139aa4627fb6357da7c80affa4a2/tools/perf/page_sets/system_health/browsing_stories.py

Owner: ----
Imgur is now disabled, though we still need to look into the actual failure. I am removing myself as the owner, it looks like something related to telemetry.
Blockedon: 679768
Owner: mythria@chromium.org
Status: Assigned (was: Available)
The root cause is in  issue 679768  & chiniforooshan@ is owning that bug. mythria@: can I assign you as owner to reenable the test what that issue is fixed?
multitab:misc:typical24 recently started failing too on many different bots with the same reason:

Exception: TraceImportError: Invalid string length

                       config                    story  latest_build                status  ok  failed  missing  expected  selected   weight
0            mac-10.12 common  multitab:misc:typical24           303  111111--------------  14       6        0        20         6  4.68559
1                linux common  multitab:misc:typical24           509  1111----------------  16       4        0        20         4  3.43900
2                win-7 common  multitab:misc:typical24           530  1111---------~------  15       4        0        19         4  3.43900
3                win-8 common  multitab:misc:typical24           555  1111----------~----~  14       4        0        18         4  3.43900
4        mac-pro-10.11 common  multitab:misc:typical24           772  11~11---------------  15       4        0        19         4  3.28510
5            mac-10.11 common  multitab:misc:typical24           513  11~1----------------  16       3        0        19         3  2.62900
6            win-7-x64 common  multitab:misc:typical24           536  1~~11---------------  15       3        0        18         3  2.38510
7          win-zenbook common  multitab:misc:typical24           436  1-1-----?1----------  16       3        1        20         3  2.19742
8    win-zenbook common [ref]  multitab:misc:typical24           436  1-1-----?1------~---  15       3        1        19         3  2.19742
9      win-10-high-dpi common  multitab:misc:typical24           441  1~1-----------------  17       2        0        19         2  1.81000
10       mac-air-10.11 common  multitab:misc:typical24           675  -11-----------------  18       2        0        20         2  1.71000
11          mac-retina common  multitab:misc:typical24           478  -1?-1-?--?--?--?----  13       2        5        20         2  1.55610
12  mac-mini-8gb-10.12 common  multitab:misc:typical24          1422  -1~--~-------~-~~~~~  11       1        0        12         1  0.90000

I'll proceed to disable that story too.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db8b09a592fde4f08dd3dd91ad1d5c470ac5f09f

commit db8b09a592fde4f08dd3dd91ad1d5c470ac5f09f
Author: perezju <perezju@chromium.org>
Date: Wed Mar 29 15:41:11 2017

[tools/perf] Disable multitab:misc:typical24

Story is failing due to large trace size.

TBR=nednguyen@google.com,vovoy@chromium.org
BUG= 704197 

Review-Url: https://codereview.chromium.org/2787473002
Cr-Commit-Position: refs/heads/master@{#460398}

[modify] https://crrev.com/db8b09a592fde4f08dd3dd91ad1d5c470ac5f09f/tools/perf/page_sets/system_health/multi_tab_stories.py

It looks like the "browse:news:nytimes@{'case': 'browse', 'group': 'news'}" story is failing with this same error as well. https://chromium-swarm.appspot.com/task?id=355025831d5e3110&refresh=10&show_raw=1 is an example of a failure.
Blocking: 664505
Summary: Re-enable stories failing due to large trace size (was: v8.runtimestats.browsing_desktop on ATI GPU on Windows on Windows-2008ServerR2-SP1 failing on chromium.perf/Win 7 ATI GPU Perf)
The stories currently disabled for due to this error are:

browse:media:imgur
multitab:misc:typical24

Re #13: I don't see browse:news:nytimes failing on system_health.* benchmarks; could that be something only showing up in the v8.* benchmarks?
Also disabled for same reason:

long_running:tools:gmail-foreground (desktop)

Comment 17 by vovoy@chromium.org, Apr 14 2017

Blocking: 710524
vovoy@, why is this blocking 710524?
I just submitted https://codereview.chromium.org/2864743002 today that enables processing large traces. It should be available after the next catapult roll. After that, could you please run the disabled tests to see if they can be re-enabled? I don't have a Mac/Win machine.

Thanks!
I'm going to try and enable 'toplevel' and the CPU time metric on system_health.common today, which couldn't happen before because the trace size blew up too much. I'll let you know how it goes!
Cc: -charliea@chromium.org
Owner: charliea@chromium.org
Reassign to charliea@ according to #20

Comment 22 by vovoy@chromium.org, May 16 2017

Cc: vovoy@chromium.org
re #18: see #11, the revised tab_switching.typical_25 used system health test multitab:misc:typical24
Project Member

Comment 23 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961a33a21ebca4823dd6e2578bdcb70013b6e4fc

commit 961a33a21ebca4823dd6e2578bdcb70013b6e4fc
Author: Charlie Andrews <charliea@chromium.org>
Date: Mon May 22 19:49:56 2017

Reenable stories disabled due to chrome:tracing trace size limitations

These issues should be resolved by
https://codereview.chromium.org/2864743002.

NOTRY=true
TBR=perezju@chromium.org
BUG= 704197 , 657433,  681839 

Change-Id: I8cbd766867ce43ca8c4e5cfb3d4a1856e01b93b5
Reviewed-on: https://chromium-review.googlesource.com/508231
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473661}
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/tools/perf/benchmarks/v8_browsing.py
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/tools/perf/page_sets/system_health/browsing_stories.py
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/tools/perf/page_sets/system_health/long_running_stories.py
[modify] https://crrev.com/961a33a21ebca4823dd6e2578bdcb70013b6e4fc/tools/perf/page_sets/system_health/multi_tab_stories.py

Status: Fixed (was: Assigned)
Project Member

Comment 25 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ea35356f880e66988f7f96ebf8a927677efbe58

commit 3ea35356f880e66988f7f96ebf8a927677efbe58
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed May 31 23:50:34 2017

Enable the CPU time metric for system_health.common

We always intended for this metric to be enabled on system health, but
were unable to do so because enabling 'toplevel' for these stories would
blow up the trace size to the point where Telemetry or trace viewer
could no longer handle it. Now that we've fixed the problems with
Telemetry and trace viewer, it should be safe to enable this.

TBR=nednguyen@google.com

Bug:  704197 
Change-Id: If5771f4eaeedd4dc34242530868a9acda059d01a
Reviewed-on: https://chromium-review.googlesource.com/520145
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476097}
[modify] https://crrev.com/3ea35356f880e66988f7f96ebf8a927677efbe58/tools/perf/benchmarks/system_health.py

Sign in to add a comment