New issue
Advanced search Search tips

Issue 704186 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

DeviceMotionEvent constructor sets interval to null by default

Project Member Reported by reillyg@chromium.org, Mar 22 2017

Issue description

The DeviceOrientation Event Specification requires that the DeviceMotionEvent.interval field be initialized to 0.
 
Components: IO>DeviceOrientation
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25b307908f44425f58b08445e42b1a3a7ca3ab00

commit 25b307908f44425f58b08445e42b1a3a7ca3ab00
Author: reillyg <reillyg@chromium.org>
Date: Thu Mar 23 02:28:19 2017

Fix default initialization for DeviceMotionEvent.interval.

The specification requires that this field be initialized to zero by
default.

BUG= 704186 

Review-Url: https://codereview.chromium.org/2758933002
Cr-Commit-Position: refs/heads/master@{#458982}

[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/LayoutTests/device_orientation/motion/create-event-expected.txt
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/LayoutTests/device_orientation/motion/create-event.html
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties-expected.txt
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/LayoutTests/device_orientation/motion/optional-event-properties.html
[delete] https://crrev.com/7cbc0c2fa215a66f620a77054250a0d635446577/third_party/WebKit/LayoutTests/external/wpt/orientation-event/devicemotionevent-init-expected.txt
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.h
[modify] https://crrev.com/25b307908f44425f58b08445e42b1a3a7ca3ab00/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4

commit 54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4
Author: reillyg <reillyg@chromium.org>
Date: Fri Mar 24 22:30:04 2017

Update DeviceMotionEvent IDL to match the specification.

In the following pull request I updated the WebIDL for initializing
DeviceMotionEvents so that it is consistent with the normative text
describing how they should be initialized,

https://github.com/w3c/deviceorientation/pull/40

While this changes web-exposed IDL definitions I do not believe that
script will be able to tell the difference as the previously specified
initialization behavior precluded setting the interval attribute to a
null value.

BUG= 704186 

Review-Url: https://codereview.chromium.org/2767473004
Cr-Commit-Position: refs/heads/master@{#459578}

[modify] https://crrev.com/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4/third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp
[modify] https://crrev.com/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.cpp
[modify] https://crrev.com/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.h
[modify] https://crrev.com/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEvent.idl
[modify] https://crrev.com/54d4a0fe8de6bb5c31be7e55a2e6c7872a1212f4/third_party/WebKit/Source/modules/device_orientation/DeviceMotionEventInit.idl

Status: Fixed (was: Assigned)
Components: -IO>DeviceOrientation -Blink>DeviceOrientation Blink>Sensor

Sign in to add a comment