New issue
Advanced search Search tips

Issue 704180 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mash: Binary name is wrong for chrome mash crash reports

Project Member Reported by jamescook@chromium.org, Mar 22 2017

Issue description

See go/f8b1d15480000000

Try clicking on "Create bug". It doesn't go to crbug.com and doesn't autofill.

I think the problem is that the product name is "ChromeOS" not "Chrome_ChromeOS"

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671

commit a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671
Author: James Cook <jamescook@chromium.org>
Date: Thu Apr 06 16:07:49 2017

crash: Tag chrome --mash crashes as product Chrome_ChromeOS

This allows the crash dashboard to use chrome-specific tooling and ensures
the crashes show up in chrome crash triage.

Also tag the process type as "mash" to differentiate it from browser and
renderer crashes.

BUG= chromium:704180 
TEST=unit test added, manually trigger crash of chrome mash process,
manually force upload, crash dashboard shows product Chrome_ChromeOS

Change-Id: I727c7231ead7682a35036eb9eb4e9e714a6f979f
Reviewed-on: https://chromium-review.googlesource.com/459117
Commit-Ready: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/user_collector_base.h
[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/user_collector_base.cc
[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/user_collector.cc
[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/user_collector.h
[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/user_collector_test.cc
[modify] https://crrev.com/a2fdfb2d1e9fb2eb14f4d5797691bd49fd289671/crash-reporter/crash_collector.h

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment