New issue
Advanced search Search tips

Issue 704174 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

xbuddy latest-dev keyword does not find a gsutil directory

Project Member Reported by gwendal@chromium.org, Mar 22 2017

Issue description

Using
cros flash --no-stateful-update --debug --disable-rootfs-verification 100.107.3.154 xbuddy://remote/veyron_minnie/latest-dev/test

ends up with a python error stack in rc/platform/dev/xbuddy.py:
  File "/mnt/host/source/src/platform/dev/xbuddy.py", line 371, in _LS
    ['ls', '-d', '--', path]).output.splitlines()
AttributeError: 'NoneType' object has no attribute 'splitlines'

However, it seems we were able to locate the right gsutil directory:
gs://chromeos-image-archive/veyron_minnie-release/R59-9390.0.0/


If I specify that image:
cros flash --no-stateful-update --debug --disable-rootfs-verification 100.107.3.154 xbuddy://remote/veyron_minnie
We go further:
09:42:46: INFO: [22/Mar/2017:09:42:46] XBUDDY Path is remote/veyron_minnie/R59-9390.0.0/test, location suffix is -release
09:42:46: INFO: [22/Mar/2017:09:42:46] XBUDDY Get artifact 'test' with board veyron_minnie and version R59-9390.0.0'. Locally? False
09:42:46: INFO: RunCommand: /mnt/host/source/.cache/common/gsutil_4.19.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' ls -- gs://chromeos-image-archive/veyron_minnie/R59-9390.0.0
09:42:47: INFO: RunCommand: /mnt/host/source/.cache/common/gsutil_4.19.tar.gz/gsutil/gsutil -o 'Boto:num_retries=10' ls -- gs://chromeos-image-archive/veyron_minnie-release/R59-9390.0.0
09:42:48: INFO: [22/Mar/2017:09:42:48] XBUDDY Resolved version R59-9390.0.0 to veyron_minnie-release/R59-9390.0.0.
09:42:48: INFO: [22/Mar/2017:09:42:48] XBUDDY Returning path to payload: veyron_minnie-release/R59-9390.0.0/chromiumos_test_image.bin
09:42:48: INFO: [22/Mar/2017:09:42:48] XBUDDY Path is remote/veyron_minnie/R59-9390.0.0/test, location suffix is -release
09:42:48: INFO: Using image veyron_minnie-release/R59-9390.0.0/chromiumos_test_image.bin


 
debug messages for both invocation.
screen-exchange
16.9 KB View Download
Owner: gwendal@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/76d0879c9fabb4adfd262052a6f7f3b0554fc90c

commit 76d0879c9fabb4adfd262052a6f7f3b0554fc90c
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Mon Apr 03 15:23:33 2017

xbuddy: fix latest-dev keyword

crash flash was not able to install image using latest-dev keyword.
Listing directory in _LS was not working.

BUG= chromium:704174 
TEST=Check 'cros flash <ip> xbuddy://remote/eve/latest-dev/test' works.

Change-Id: Ic8e9465836308d7897c67861a13527415cd0c2dc
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/465447
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/76d0879c9fabb4adfd262052a6f7f3b0554fc90c/xbuddy.py

Comment 4 Deleted

Comment 5 Deleted

Components: Infra>Client>ChromeOS>Build
Labels: OS-Chrome
Status: Fixed (was: Started)

Sign in to add a comment