+zkoch: You're more familiar with the spec. Can you triage this bug before jinho.bang works on it, please?

Wrong bug, sorry!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec033c55fbc09dade60bc543373deb86c517b1b

commit aec033c55fbc09dade60bc543373deb86c517b1b
Author: jinho.bang <jinho.bang@samsung.com>
Date: Tue Mar 28 09:36:01 2017

PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate.

The current implementation uses PaymentDetails structure when creating
PaymentRequest object and calling updateWith(). But some parameters like error
are only allowed in the updateWith(). If developer tries to use error parameter
when creating PaymentRequest, then throws exception. So, to solve the problem
in the latest spec[1][2], common parts are combined and each different parts
are separated into PaymentDetailsInit and PaymentDetailsUpdate.

This change only affects input dictionaries and doesn't break existing behavior.
Therefore, we don't need a intent to implement and ship.

[1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
[2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary

BUG= 704166 

Review-Url: https://codereview.chromium.org/2748093003
Cr-Commit-Position: refs/heads/master@{#460053}

[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/components/payments/content/payment_details_validation.cc
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/components/payments/content/payment_request.cc
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/components/payments/content/payment_request.mojom
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/AbortTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/CompleteTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[delete] https://crrev.com/08dded86021b3231e8db6ea77163b88c036bba76/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[add] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentDetailsBase.idl
[add] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentDetailsInit.idl
[add] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentDetailsUpdate.idl
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/aec033c55fbc09dade60bc543373deb86c517b1b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/debb70fbd588bf22ae28d686e705ef27a3c123a5

commit debb70fbd588bf22ae28d686e705ef27a3c123a5
Author: kolos <kolos@chromium.org>
Date: Tue Mar 28 10:34:33 2017

Revert of PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate. (patchset #10 id:180001 of https://codereview.chromium.org/2748093003/ )

Reason for revert:
This CL broke compilation on Android and Mac.

Original issue's description:
> PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate.
>
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error parameter
> when creating PaymentRequest, then throws exception. So, to solve the problem
> in the latest spec[1][2], common parts are combined and each different parts
> are separated into PaymentDetailsInit and PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing behavior.
> Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG= 704166 
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed: https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373deb86c517b1b

TBR=tkent@chromium.org,foolip@chromium.org,haraken@chromium.org,rouslan@chromium.org,tsepez@chromium.org,jinho.bang@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 704166 

Review-Url: https://codereview.chromium.org/2779013002
Cr-Commit-Position: refs/heads/master@{#460055}

[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/components/payments/content/payment_details_validation.cc
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/components/payments/content/payment_request.cc
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/components/payments/content/payment_request.mojom
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/AbortTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/CompleteTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[add] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[delete] https://crrev.com/5c732104d0278822b4df84d76362f60d2929b037/third_party/WebKit/Source/modules/payments/PaymentDetailsBase.idl
[delete] https://crrev.com/5c732104d0278822b4df84d76362f60d2929b037/third_party/WebKit/Source/modules/payments/PaymentDetailsInit.idl
[delete] https://crrev.com/5c732104d0278822b4df84d76362f60d2929b037/third_party/WebKit/Source/modules/payments/PaymentDetailsUpdate.idl
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/debb70fbd588bf22ae28d686e705ef27a3c123a5/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b

commit fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b
Author: jinho.bang <jinho.bang@samsung.com>
Date: Wed Mar 29 08:08:02 2017

Reland "PaymentRequest: Introduce PaymentDetailsInit and PaymentDetailsUpdate."

Reason for revert:
This CL broke compilation on Android and Mac. ( https://crbug.com/704166 )

Original issue's description:
> The current implementation uses PaymentDetails structure when creating
> PaymentRequest object and calling updateWith(). But some parameters like error
> are only allowed in the updateWith(). If developer tries to use error
> parameter when creating PaymentRequest, then throws exception. So, to solve
> the problem in the latest spec[1][2], common parts are combined and each
> different parts are separated into PaymentDetailsInit and
> PaymentDetailsUpdate.
>
> This change only affects input dictionaries and doesn't break existing
> behavior. Therefore, we don't need a intent to implement and ship.
>
> [1] https://w3c.github.io/browser-payment-api/#paymentdetailsinit-dictionary
> [2] https://w3c.github.io/browser-payment-api/#paymentdetailsupdate-dictionary
>
> BUG= 704166 
>
> Review-Url: https://codereview.chromium.org/2748093003
> Cr-Commit-Position: refs/heads/master@{#460053}
> Committed: https://chromium.googlesource.com/chromium/src/+/aec033c55fbc09dade60bc543373deb86c517b1b

BUG= 704166 

Review-Url: https://codereview.chromium.org/2780773004
Cr-Commit-Position: refs/heads/master@{#460323}

[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/components/payments/content/payment_details_validation.cc
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/components/payments/content/payment_request.cc
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/components/payments/content/payment_request.mojom
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/LayoutTests/payments/payment-request-interface-expected.txt
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/LayoutTests/payments/payment-request-interface.html
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/AbortTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/CanMakePaymentTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/CompleteTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp
[delete] https://crrev.com/28ea8191e57cf1a852a9e48f5298a3049687b006/third_party/WebKit/Source/modules/payments/PaymentDetails.idl
[add] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentDetailsBase.idl
[add] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentDetailsInit.idl
[add] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentDetailsUpdate.idl
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/fcb5ec998c25a649fab3bbbc3ab1e4edf46fa97b/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h

 Issue 701252  has been merged into this issue.