New issue
Advanced search Search tips

Issue 704158 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

No accessibility Label, ID or description for the magnifying glass, star, or clock icons shown in autosuggest for iPads

Project Member Reported by linds...@chromium.org, Mar 22 2017

Issue description

App Version:58.0.3029.31
iOS Version: iOS 10.3. beta 7
Device: iPad Pro 

Steps to reproduce:
  1. Turn on Voice Over
  2. Open new tab and place cursor in omnibox
  3. Start typing the url for a site saved in bookmarks, or that has been searched for recently
  4. Tap on one of the suggestions to hear the accessibility actions and description available

Observed results:
No label or indication is present that the suggestion is from bookmarks or search history, as indicated by the star or clock icon in the autosuggest drop down.

Expected results:
A label or indication should be present that the suggestion is from bookmarks or search history, as indicated by the star or clock icon in the autosuggest drop down.

This also impedes any automated EG test coverage from accessing or verifying the icons.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Observed behavior in Chrome Mobile on Android: n/a
Check for similar behavior on Firefox/Safari: n/a
Bug reproducible on current stable build (App Version, iOS Version): Yes M57
Bug reproducible on the current beta channel (dogfoody) build (App Version, iOS Version): Yes M58

 
Cc: lpromero@chromium.org
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec4834647c37a0b0b3a6b7cfa0a45f590eb9bd46

commit ec4834647c37a0b0b3a6b7cfa0a45f590eb9bd46
Author: lindsayw <lindsayw@chromium.org>
Date: Fri Mar 24 18:38:18 2017

Add accessibility ID to the icon next to autosuggest drop down for iPads.

BUG=704158

Review-Url: https://codereview.chromium.org/2769213004
Cr-Commit-Position: refs/heads/master@{#459487}

[modify] https://crrev.com/ec4834647c37a0b0b3a6b7cfa0a45f590eb9bd46/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm

Labels: NewComponent-AccessibilityNewComponent-Accessibility NewComponent-Accessibility-Browser

Comment 4 Deleted

Labels: -newcomponent-accessibility-browser
Labels: Needs-Feedback
Did the changelist on the bug fix this issue or is there more to do?
(E.g., it looks like it added IDs.  It's not clear to me whether it also added labels and descriptions that are mentioned in the bug summary.)
Labels: -Needs-Feedback
Tested on latest M60.0.3112.72 on iPad Air(iOS 11) and iPad Mini(iOS 10)

Followed the steps mentioned in Comment#0, no label or description for the star or clock or magnifying glass icon is present in the autosuggest drop down. i.e. using voice over, the user will not be aware whether the suggestion is from the bookmark or history.

Link to video:
https://drive.google.com/a/google.com/file/d/0B8Cek8RsDbF8bzE2VmlIWF9INkk/view?usp=sharing

Cc: -lpromero@chromium.org rohitrao@chromium.org
Owner: stkhapugin@chromium.org

Sign in to add a comment