DevTools Network tab shows SPDY for memory-cached resources |
|||||||
Issue descriptionChrome Version: 59.3047 What steps will reproduce the problem? (1) Visit a page (e.g. https://www.accuweather.com) that results in pulls from the memory cache Observe: Requests that hit the memory cache show "spdy" as the protocol Expect: No such claim, because we don't enable SPDY in Chrome any more. getProtocol() here https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/network_handler.cc?l=381&rcl=7569715801917d9c4dd1bdc0182bd38ff3e43cae returns SPDY if the was_fetched_via_spdy flag is true, but that flag is a bit of a lie; it's true for QUIC (verified) and probably H2 (didn't look) as well. If we cannot fix the protocol annotation on the MemoryCache responses, we should probably change the default fallback to either "" or "h2" since the latter is most likely.
,
Dec 13 2017
,
Jul 1
This issue still exists in 69.0.3477.0 and also applies to disk-cached resources.
,
Jul 2
I also encountered this issue in Chrome 67. It seems that not only disk-cached and memory-cached resources were shown as "SPDY"。I had already disabled cache. https://groups.google.com/a/chromium.org/forum/#!topic/chromium-discuss/PYCV9EuYers
,
Jul 24
I'm seeing this too on the embedded resources for a page like facebook.com. It occurs whether the resources are cached or downloaded during the page load. However, if I directly load one of the resource URLs with the location bar, e.g.: https://static.xx.fbcdn.net/rsrc.php/v3/yr/l/0,cross/XjOlbZhxXqf.css It is correctly showing the protocol as 'h2'. The problem also occurs when using the chrome.debugger API in an extension.
,
Sep 18
,
Oct 5
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60d5b1ea70d1fd7a8acd214c9b0a7661b20ee9e4 commit 60d5b1ea70d1fd7a8acd214c9b0a7661b20ee9e4 Author: Joey Arhar <jarhar@chromium.org> Date: Mon Oct 08 19:08:35 2018 [DevTools] Replace "spdy" initiators with "h2" SPDY in Chrome simply refers to HTTP/2 now: https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/iwUnvL0Ul6Q Bug: 704146 , 881567 Change-Id: Ida5871c3a738755325413b3dd042af5d442497c1 Reviewed-on: https://chromium-review.googlesource.com/c/1268959 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#597641} [modify] https://crrev.com/60d5b1ea70d1fd7a8acd214c9b0a7661b20ee9e4/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/60d5b1ea70d1fd7a8acd214c9b0a7661b20ee9e4/third_party/blink/renderer/core/inspector/inspector_network_agent.cc
,
Oct 8
,
Oct 9
Tried reproducing the issue on reported chrome version #59.0.3047.0 using Windows & by following steps below. Steps: ===== 1.Launched chrome. 2.Navigated to "https://www.accuweather.com". 3.Opened DevTools>Network. 4.Refreshed the page and observed the type of protocols under Network tab. 5.Unable to observe "spdy" type of protocol. Note: Tried to reproduce the issue on chrome version #67.0.3369.99 as per comment#4 but unable to observe "spdy" type of protocol. Attached screencast for reference. @Joey Arhar: Could you please review the attached screencast and let us know if anything is being missed here so that it would be really helpful in verifying the fix. Thanks.!
,
Oct 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ac0119e24046a79368f4a347fa637ff8a0db767 commit 4ac0119e24046a79368f4a347fa637ff8a0db767 Author: Joey Arhar <jarhar@chromium.org> Date: Wed Oct 10 19:17:41 2018 [DevTools] Remove duplicate ALPN information from blink::ResourceLoadInfo npn_negotiated_protocol in ResourceLoadInfo is only used by DevTools and doesn't get set when raw headers are unavailable, such as cross origin requests. This resulted in a lack of information for cross origin requests and subsequently being wrongly labeled as "spdy." alpn_negotiated_protocol in blink::ResourceResponse always gets set, so it should be used instead of the one in ResourceLoadInfo. Bug: 704146 , 881567 Change-Id: Iedd33834bc5e0c22ff3bf620307b1538563d9141 Reviewed-on: https://chromium-review.googlesource.com/c/1272596 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#598441} [modify] https://crrev.com/4ac0119e24046a79368f4a347fa637ff8a0db767/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/4ac0119e24046a79368f4a347fa637ff8a0db767/third_party/blink/renderer/core/inspector/inspector_network_agent.cc [modify] https://crrev.com/4ac0119e24046a79368f4a347fa637ff8a0db767/third_party/blink/renderer/platform/exported/web_http_load_info.cc [modify] https://crrev.com/4ac0119e24046a79368f4a347fa637ff8a0db767/third_party/blink/renderer/platform/loader/fetch/resource_load_info.h
,
Nov 12
Issue 904109 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by allada@chromium.org
, Apr 6 2017Status: Assigned (was: Untriaged)