Issue metadata
Sign in to add a comment
|
Trybot success/failure are difficult to discern |
||||||||||||||||||
Issue descriptionFor users who can't distinguish red and green, trybot success/failure might be unclear. I recommend putting a heavy border around failed bots or some other visual marker for them. Also, there's no indication of the bot status for screenreader users, so maybe they should have accessible titles attached that indicate success/failure.
,
Aug 5 2016
,
Aug 17 2016
,
Aug 17 2016
,
Oct 5 2016
,
Oct 6 2016
,
Jan 10 2017
,
Mar 21 2017
,
Mar 22 2017
Yay accessibility! Thanks for keeping us honest.
,
Mar 22 2017
,
Mar 23 2017
With the current scheme, I believe that someone with monochromacy can tell the difference https://screenshot.googleplex.com/wdZsZxPu1q1 I can't work on this well from home so note to self: use a ::before selector to add a x/check icon before each link, and move the setting of the background color up to the parent 'build' div so that the icon is inside the color field.
,
Mar 23 2017
Thank you, that looks much better :)
,
Mar 24 2017
I add icons here: https://chromium-review.googlesource.com/459229 And add aria here: https://chromium-review.googlesource.com/459067
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/d5d205801317859bdca03196bad8c924f4304cfb commit d5d205801317859bdca03196bad8c924f4304cfb Author: Aaron Gable <agable@chromium.org> Date: Wed Mar 29 00:34:19 2017 Add running/success/failure icons to buildbucket display This increases accessibility for users who cannot rely on color alone to distinguish build states. Bug: 704145 Change-Id: I67b8751bc6635b7fcfb7e2fe7f03c7cb2192e457 Reviewed-on: https://chromium-review.googlesource.com/459229 Reviewed-by: Andrew Bonventre <andybons@chromium.org> [add] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/images/canceled.svg [modify] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/LICENSE [modify] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/cr-buildbucket-view.html [add] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/images/started.svg [add] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/images/failure.svg [add] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/images/success.svg [add] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/images/infraFailure.svg [modify] https://crrev.com/d5d205801317859bdca03196bad8c924f4304cfb/src/main/resources/static/cr-buildbucket-view.js
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/3d58e43c985c65e3e4c60fdbeaf86b27fa10255c commit 3d58e43c985c65e3e4c60fdbeaf86b27fa10255c Author: Aaron Gable <agable@chromium.org> Date: Wed Mar 29 00:38:19 2017 Add aria labels to success/failure indicators Bug: 704145 Change-Id: I391b874f4c729a7d57323f1164b56c86af76510b Reviewed-on: https://chromium-review.googlesource.com/459067 Reviewed-by: Andrew Bonventre <andybons@chromium.org> [modify] https://crrev.com/3d58e43c985c65e3e4c60fdbeaf86b27fa10255c/src/main/resources/static/cr-buildbucket-view.html
,
Mar 29 2017
Both CLs have landed! I really hope this is a good improvement for our users. The changes are being imported into prod now, and should deploy tomorrow. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by andyb...@chromium.org
, Jul 19 2016Owner: andyb...@chromium.org
Status: Accepted (was: New)