New issue
Advanced search Search tips

Issue 704145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----


Previous locations:
gerrit:4280


Sign in to add a comment

Trybot success/failure are difficult to discern

Project Member Reported by ellyjo...@chromium.org, Jul 19 2016

Issue description

For users who can't distinguish red and green, trybot success/failure might be unclear. I recommend putting a heavy border around failed bots or some other visual marker for them.

Also, there's no indication of the bot status for screenreader users, so maybe they should have accessible titles attached that indicate success/failure.
 
Labels: Hotlist-Chromium
Owner: andyb...@chromium.org
Status: Accepted (was: New)
Labels: Pri-2

Comment 3 by logan@google.com, Aug 17 2016

Labels: Priority-2

Comment 4 by logan@google.com, Aug 17 2016

Labels: -pri-2
Labels: -Priority-2 Priority-3 Milestone-Chromium-Afterglow
Owner: ----
Labels: -Milestone-Chromium-Afterglow Milestone-Chromium-Launch

Comment 7 by logan@google.com, Jan 10 2017

Owner: wyatta@google.com

Comment 8 by wyatta@google.com, Mar 21 2017

Components: -PolyGerrit
Owner: aga...@chromium.org

Comment 9 by agable@google.com, Mar 22 2017

Labels: -Hotlist-Chromium -Priority-3 -Milestone-Chromium-Launch Milestone-Launch Proj-Gerrt-Migration Priority-2
Yay accessibility! Thanks for keeping us honest.

Comment 10 by agable@google.com, Mar 22 2017

Project: chromium
Moved issue gerrit:4280 to now be  issue chromium:704145 .
Status: Started (was: Accepted)
With the current scheme, I believe that someone with monochromacy can tell the difference https://screenshot.googleplex.com/wdZsZxPu1q1

I can't work on this well from home so note to self: use a ::before selector to add a x/check icon before each link, and move the setting of the background color up to the parent 'build' div so that the icon is inside the color field.
Thank you, that looks much better :)
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 29 2017

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/3d58e43c985c65e3e4c60fdbeaf86b27fa10255c

commit 3d58e43c985c65e3e4c60fdbeaf86b27fa10255c
Author: Aaron Gable <agable@chromium.org>
Date: Wed Mar 29 00:38:19 2017

Add aria labels to success/failure indicators

Bug:  704145 
Change-Id: I391b874f4c729a7d57323f1164b56c86af76510b
Reviewed-on: https://chromium-review.googlesource.com/459067
Reviewed-by: Andrew Bonventre <andybons@chromium.org>

[modify] https://crrev.com/3d58e43c985c65e3e4c60fdbeaf86b27fa10255c/src/main/resources/static/cr-buildbucket-view.html

Status: Fixed (was: Started)
Both CLs have landed! I really hope this is a good improvement for our users. The changes are being imported into prod now, and should deploy tomorrow.

Sign in to add a comment