New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704136 link

Starred by 0 users
Status: Assigned
Owner:
guidou@chromium.org
Cc:
hta@chromium.org
ar...@chromium.org
█ c.pa...@samsung.com
guidou@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on: View detail
issue 921006
issue 923394
Blocking:
issue 787245
issue 787254
issue 787261



Sign in to add a comment

Onion soup content/renderer/media/stream

Project Member Reported by guidou@chromium.org, Mar 22 2017 
Currently, a lot of the processing for getUserMedia, enumerateDevices and the devicechange event is done in content::UserMediaClientImpl.

Now that Blink communicate directly with the browser via Mojo, much of the UserMediaClientImpl code can be moved to Blink.

This is important because:
* It would reduce complexity by reducing the large number of existing layers.
* It would allow using layout tests to test things such as constraints, whose processing is currently in content.

The migration requires migrating MediaStreamDispatcherHost to Mojo and updating MediaDevicesDispatcher (already Mojo) to return types that can be used in Blink.

A full migration would also include moving the MediaStreams framework to Blink, but that is a separate project since that framework depends on several modules in content/ and media/ which are not yet accessible from Blink.

Comment 1 by guidou@chromium.org, Mar 22 2017

Cc: hta@chromium.org
Components: Blink>GetUserMedia

Comment 2 by guidou@chromium.org, Sep 13 2017 

UserMediaClientImpl handles getUserMedia and enumerateDevices requests, but they are largely separate. It would make sense to first migrate enumerateDevices which largely depends just on MediaDevicesDispatcher. Filed  bug 764680  for that.

Comment 3 by guidou@chromium.org, Dec 8 2017

Blocking: 787254

Comment 4 by guidou@chromium.org, Jan 22 2018

Cc: c.pa...@samsung.com
c.padhi@: would you be interested in working on this bug?

Comment 5 by c.pa...@samsung.com, Jan 22 2018 

Sure. We are already done with enumerateDevices and devicechange migration.
So, should the focus now be on getUserMedia migration?
How do you think we should proceed for this bug? May be if you could please outline few things like the approach, where should we begin, etc.

Comment 6 by c.pa...@samsung.com, Jan 24 2018 

guidou@: Your response on the above, please?

Comment 7 by c.pa...@samsung.com, Jan 29 2018 

Hi,

Sorry for the delay in response as we had holidays last week.
Prior to the doc shared by you, I knew that this migration would be complex by looking at the code related to getUserMedia in UserMediaClientImpl. I also had a look at the doc today. I am still interested and would like to continue with this work.

Please suggest which one should I take up first.

Comment 8 by guidou@chromium.org, Jan 7

Blocking: 787245

Comment 9 by mcasas@chromium.org, Jan 7

Blocking: 787261

Comment 10 by ar...@chromium.org, Jan 8

Cc: ar...@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/030c2f8dd340c537c78e9530320dacb6cc92b4da

commit 030c2f8dd340c537c78e9530320dacb6cc92b4da
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Jan 10 11:59:16 2019

De-inline KURL equality operators.

Keeping them inline results in compilation issues with blink bindings
of media interfaces that use URLs.

This is a requirement for crrev.com/c/1389998

Bug: 704136
Change-Id: I4d87e2f6c19f9a91a3b51eee40f2cb7d59b5d56f
Reviewed-on: https://chromium-review.googlesource.com/c/1401044
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621547}
[modify] https://crrev.com/030c2f8dd340c537c78e9530320dacb6cc92b4da/third_party/blink/renderer/platform/weborigin/kurl.cc
[modify] https://crrev.com/030c2f8dd340c537c78e9530320dacb6cc92b4da/third_party/blink/renderer/platform/weborigin/kurl.h

Comment 12 by guidou@chromium.org, Jan 11

Blockedon: 921006
Summary: Onion soup content/renderer/media/stream (was: Move content::UserMediaClientImpl to Blink)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73fa66396d3c871a43f0f0e0ec28236670d7da9a

commit 73fa66396d3c871a43f0f0e0ec28236670d7da9a
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Jan 14 18:46:26 2019

Move MediaStream Mojo and public interfaces to Blink.

This is the first step for Onion Souping MediaStreams.

This CL moves media_stream.mojom from content/public/common to
blink/public/mojom.
Together with the mojom files, the following headers containing
typemapped definitions were moved to blink/public/common:
 * content/public/common/media_stream_request.h
 * content/common/media/media_stream_controls.h

content/public/common/media_stream_request.h contained two
browser-only
types, which were instead moved to
content/public/browser/media_stream_request.h

Changes in C++ files outside third_party/blink are mechanical or close
to mechanical. They consist of updating #includes and replacing the
content namespace with the blink namespace for the affected types.

DEPS files for android_webview/browser and extensions/browser have been
modified to include a reference the new blink/public/common/mediastream,
while the DEPS files for blink/common and blink/public/common now
include a reference to media.

The only BUILD.gn file outside third_party/blink containing nontrivial
changes is media/mojo/interfaces/BUILD.gn, with the changes addressing
a compilation issue on Windows component builds.


Bug: 704136
Change-Id: I2ded125142365e9d0ae0bc62e6be94d66f773414
Reviewed-on: https://chromium-review.googlesource.com/c/1389998
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622534}
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/android_webview/browser/DEPS
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/android_webview/browser/permission/media_access_permission_request.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/android_webview/browser/permission/media_access_permission_request.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/android_webview/browser/permission/media_access_permission_request_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/android/tab_web_contents_delegate_android.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/arc/screen_capture/arc_screen_capture_session.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/login/ui/webui_login_view.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/policy/status_uploader.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/extensions/api/tab_capture/offscreen_tabs_owner.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/extensions/chrome_extension_host_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/extensions/chrome_extension_host_delegate.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/capture_access_handler_base.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/capture_access_handler_base.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/cast_mirroring_service_host.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/chromeos_login_media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/chromeos_login_media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/extension_media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/extension_media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/offscreen_tab.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/offscreen_tab.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/public_session_media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/public_session_media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/public_session_tab_capture_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/public_session_tab_capture_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/desktop_capture_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/desktop_capture_access_handler_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/desktop_capture_devices_util.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/desktop_capture_devices_util.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/display_media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/display_media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/display_media_access_handler_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_capture_devices_dispatcher.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_capture_indicator.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_capture_indicator.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_device_permissions.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/media_stream_infobar_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/permission_bubble_media_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/tab_capture_access_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/media/webrtc/tab_capture_access_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/apps/chrome_app_delegate.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/ash/media_client.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/ash/media_client.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/browser.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/browser.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chromecast/browser/cast_web_view_default.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chromecast/browser/cast_web_view_default.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chromecast/browser/extensions/cast_extension_host_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/chromecast/browser/extensions/cast_extension_host_delegate.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/mirroring/browser/single_client_video_capture_host.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/mirroring/browser/single_client_video_capture_host.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/mirroring/browser/single_client_video_capture_host_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/offline_pages/content/background_loader/background_loader_contents.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/offline_pages/content/background_loader/background_loader_contents.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/components/offline_pages/content/background_loader/background_loader_contents_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/image_capture/image_capture_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/media/media_devices_permission_checker.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/media/media_devices_permission_checker_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/media/media_devices_util.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_delegate_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_delegate_impl.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_delegate_impl_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_device_manager.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_device_manager.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_input_device_manager_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_output_authorization_handler.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/fake_video_capture_device_launcher.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/fake_video_capture_device_launcher.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/in_process_video_capture_device_launcher.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_capture_devices_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_capture_devices_impl.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_dispatcher_host.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_manager_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_provider.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_track_metrics_host.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_track_metrics_host.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_ui_proxy.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_ui_proxy.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/mock_video_capture_provider.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/service_video_capture_device_launcher.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/service_video_capture_device_launcher.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_controller.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_manager.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_provider.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_provider_switcher.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/media/video_capture_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/renderer_host/render_process_host_impl.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/speech/speech_recognition_manager_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/common/BUILD.gn
[delete] https://crrev.com/c1d0754f16b949bb1e3ec2081f103943d93298d6/content/common/media/media_stream.typemap
[delete] https://crrev.com/c1d0754f16b949bb1e3ec2081f103943d93298d6/content/common/media/media_stream_mojom_traits.cc
[delete] https://crrev.com/c1d0754f16b949bb1e3ec2081f103943d93298d6/content/common/media/media_stream_mojom_traits.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/common/typemaps.gni
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/BUILD.gn
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/content_browser_client.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_capture_devices.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_device_id.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_device_id.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_observer.h
[add] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_stream_request.cc
[add] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/media_stream_request.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/speech_recognition_session_context.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/video_capture_device_launcher.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/public/common/BUILD.gn
[delete] https://crrev.com/c1d0754f16b949bb1e3ec2081f103943d93298d6/content/public/common/media_stream_request.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/apply_constraints_processor.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/local_media_stream_audio_source.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/local_media_stream_audio_source.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_audio_processor.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_audio_source.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_audio_source.h
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_constraints_util.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/73fa66396d3c871a43f0f0e0ec28236670d7da9a/content/renderer/media/stream/media_stream_constraints_util_video_con

Comment 14 by guidou@chromium.org, Jan 16

Labels: -Pri-3 Pri-2
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/265d0d3c6570a1523f1eb15e8632f51a4021b7eb

commit 265d0d3c6570a1523f1eb15e8632f51a4021b7eb
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Jan 16 13:28:26 2019

Remove reference to media::AudioDeviceDescription from content::MediaDeviceInfo

Types in media/audio, such as media::AudioDeviceDescription should not be accessed
from the renderer process.
The constructor in MediaDeviceInfo that uses AudioDeviceDescription is
currently used only on the browser, but since MediaDeviceInfo is defined
in content/common, it is also available in the renderer process.
This CL removes the reference to media::AudioDeviceDescription in a
MediaDeviceInfo constructor and replaces the call with another
constructor passing fields more explicitly.

This CL is preparation work for moving MediaDeviceInfo to Blink.

Bug: 704136

MediaDeviceInfo will be moved to Blink

Change-Id: I7da4bb4cee30aa0f6a26da5a7a5fc9516f618a9d
Reviewed-on: https://chromium-review.googlesource.com/c/1405048
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623214}
[modify] https://crrev.com/265d0d3c6570a1523f1eb15e8632f51a4021b7eb/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/265d0d3c6570a1523f1eb15e8632f51a4021b7eb/content/common/media/media_devices.cc
[modify] https://crrev.com/265d0d3c6570a1523f1eb15e8632f51a4021b7eb/content/common/media/media_devices.h
[modify] https://crrev.com/265d0d3c6570a1523f1eb15e8632f51a4021b7eb/content/common/media/media_devices_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d45f3ed619219b9f664fcbc564933c0f9ecca078

commit d45f3ed619219b9f664fcbc564933c0f9ecca078
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Jan 16 13:48:18 2019

Move MediaDevices C++ and Mojo interfaces to blink/public/common and blink/public/mojom

The Mojo interface was defined in public/platform/ and the C++ interface was defined in
content/common.

This is part of onion souping the mediastream module.

Bug: 704136
Change-Id: I06cb202e791e445779b533ecc4896d086638300e
Reviewed-on: https://chromium-review.googlesource.com/c/1405314
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623218}
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/media/media_devices_permission_checker.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/media/media_devices_permission_checker.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/media/media_devices_permission_checker_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/media/media_devices_util.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/media/media_devices_util.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/audio_output_authorization_handler.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_dispatcher_host.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_dispatcher_host_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_manager.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_devices_manager_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/old_render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/render_frame_audio_input_stream_factory.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/browser/renderer_host/media/video_capture_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/common/BUILD.gn
[delete] https://crrev.com/711d2f0f19c70acd7d6ce6c1d3460cac72e31bbd/content/common/media/media_devices.cc
[delete] https://crrev.com/711d2f0f19c70acd7d6ce6c1d3460cac72e31bbd/content/common/media/media_devices.h
[delete] https://crrev.com/711d2f0f19c70acd7d6ce6c1d3460cac72e31bbd/content/common/media/media_devices.typemap
[delete] https://crrev.com/711d2f0f19c70acd7d6ce6c1d3460cac72e31bbd/content/common/media/media_devices_mojom_traits.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/common/typemaps.gni
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/apply_constraints_processor.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/media_stream_constraints_util.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/media_stream_constraints_util_audio.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/media_stream_constraints_util_video_device.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/user_media_client_impl.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/user_media_client_impl_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/media/stream/user_media_processor.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/pepper/pepper_media_device_manager.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/renderer/pepper/pepper_media_device_manager.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/content/test/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/common/BUILD.gn
[add] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/common/mediastream/media_devices.cc
[rename] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/common/mediastream/media_devices_mojom_traits.cc
[rename] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/common/mediastream/media_devices_unittest.cc
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/common/BUILD.gn
[add] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/common/mediastream/media_devices.h
[add] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/common/mediastream/media_devices.typemap
[add] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/common/mediastream/media_devices_mojom_traits.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/mojom/mediastream/media_devices.mojom
[delete] https://crrev.com/711d2f0f19c70acd7d6ce6c1d3460cac72e31bbd/third_party/blink/public/platform/modules/mediastream/OWNERS
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/public/public_typemaps.gni
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/renderer/bindings/modules/v8/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/renderer/modules/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/renderer/modules/mediastream/BUILD.gn
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/renderer/modules/mediastream/media_device_info.h
[modify] https://crrev.com/d45f3ed619219b9f664fcbc564933c0f9ecca078/third_party/blink/renderer/modules/mediastream/media_devices.h

Comment 17 by guidou@chromium.org, Jan 18 (5 days ago)

Blockedon: 923394
►

Sign in to add a comment