Run Field Trial and Finch Trial for VSync Aligned Input |
||
Issue descriptionThis issue tracks Field Trial and Finch Trial for VSync Aligned Input.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/232fbc4bc87a4c35ea8ab60e1f7ff8e4e8e14de5 commit 232fbc4bc87a4c35ea8ab60e1f7ff8e4e8e14de5 Author: chongz <chongz@chromium.org> Date: Fri Mar 31 20:14:35 2017 Revert of Enable VsyncAlignedInput to Field Trial (patchset #1 id:40001 of https://codereview.chromium.org/2752363002/ ) Reason for revert: Reverting due to issue 704732 . Will try to find the root cause before re-landing. Original issue's description: > Enable VsyncAlignedInput to field trial > > Enable Field Trial on Android, ChromeOS, Linux, Mac, Win. > > This patch will cause expected 1 frame delay in > "scheduler.tough_scheduling_cases.first_gesture_scroll_update_latency". > > Reasons for the delay: > The synthetic input controller sends |TouchMove| right before |BeginFrame|, which > means the ack will come back later and the generated |GestureScrollUpdate| will falls > into next |BeginFrame|. > > This is fine since the actual scroll result won't be rendered until next frame with or > without this patch. > > BUG= 704134 > > Review-Url: https://codereview.chromium.org/2752363002 > Cr-Commit-Position: refs/heads/master@{#458921} > Committed: https://chromium.googlesource.com/chromium/src/+/5a7f45dab8372cb7b80ee24dfb137a7ced2049ea TBR=isherman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 704134 Review-Url: https://codereview.chromium.org/2791663002 Cr-Commit-Position: refs/heads/master@{#461202} [modify] https://crrev.com/232fbc4bc87a4c35ea8ab60e1f7ff8e4e8e14de5/testing/variations/fieldtrial_testing_config.json
,
Jun 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/379f637084f5ccfe96bba687afaad8a75f53c3d5 commit 379f637084f5ccfe96bba687afaad8a75f53c3d5 Author: Chong Zhang <chongz@chromium.org> Date: Mon Jun 26 21:23:59 2017 Re-enable VsyncAlignedInput to Field Trial Re-enable Field Trial on Android, ChromeOS, Linux, Mac, Win. The original Field Trial was reverted due to telemetry regression in |mean_pixels_checkerboarded| and |first_gesture_scroll_update_latency|. See crbug.com/704732 BUG= 704134 Change-Id: I69916381809913e17a2676b501fb426d517acf2f Reviewed-on: https://chromium-review.googlesource.com/547095 Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#482405} [modify] https://crrev.com/379f637084f5ccfe96bba687afaad8a75f53c3d5/testing/variations/fieldtrial_testing_config.json
,
Aug 8 2017
Issues revealed by Field Trial was tracked and fixed in issue 737379 . Finch Trial was enabled in cl/163204035 and the data obtained was as expected. Closing as fixed. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 22 2017