Tile icon not rendered when reverting removal |
||||
Issue description0. Enable Chrome Home 1. Pull up sheet 2. Context Menu on tile + remove 3. Tap undo on the snackbar (might need to close the sheet first, see issue 704128 ) 4. Observe the tile that came back Expected: tile has an icon Actual: tile has no icon It might have to do with the view not being visible when it is reattached, which causes the bitmap is was holding to not be rerendered. A fix would be to explicitly set the icon on the view again, but that issue might be only caused by issue 704128 . To be revisited when the snackbar properly works inside of the bottom sheet. Note: Issue does not repro on regular NTP, when removing the tile, scrolling all the way to the bottom before tapping undo, which also would mean that the view is not visible when the tile is reattached.
,
Apr 18 2017
The bug repros with issue 704128 fixed: even when not closing the sheet, the tiles added later don't show their icon.
,
Apr 18 2017
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de49e186e1af90c584ba9d1b263a8b7afd215a04 commit de49e186e1af90c584ba9d1b263a8b7afd215a04 Author: dgn <dgn@chromium.org> Date: Mon Apr 24 14:24:19 2017 [Suggestions] Fix tile icon rendering issue in Chrome Home Notifying the RecyclerView of item changes without providing a payload makes it create a new ViewHolder to replace the existing one. The code assumed the ViewHolder and the associated view are unique and ended up updating 2 different view alternatively, triggering the visual glitch. BUG= 704130 Review-Url: https://codereview.chromium.org/2827363002 Cr-Commit-Position: refs/heads/master@{#466629} [modify] https://crrev.com/de49e186e1af90c584ba9d1b263a8b7afd215a04/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java [modify] https://crrev.com/de49e186e1af90c584ba9d1b263a8b7afd215a04/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGrid.java
,
Apr 25 2017
Should be fixed in 60.0.3080.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by dgn@chromium.org
, Mar 22 2017