New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704128 link

Starred by 2 users
Status: Fixed
Owner:
twelling...@chromium.org
Closed: Apr 2017
Cc:
█ rachelis@google.com
twelling...@chromium.org
mvanouwe...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 704130



Sign in to add a comment

Snackbars do not show inside of the bottom sheet

Project Member Reported by dgn@chromium.org, Mar 22 2017 
Actions that show show a snackar (e.g. remove a bookmark, download, NTP tile, etc) do so outside of the bookmark, so one has to quickly close the bottom sheet to undo the action.

Implementation proposal: Snackbars are relevant to a given context, so there could be 2 snackbar managers, one for inside the bottom sheet and one for the activity in general. That would avoid having to transfer the snackbars when opening/closing the sheet, and make implementation much easier, while being also more doable in terms of animations and co.

rachelis@, cleer@, thoughts?

Comment 1 by dgn@chromium.org, Mar 22 2017

Blocking: 704130

Comment 2 by rachelis@google.com, Mar 24 2017

Labels: -zine-ux

Comment 3 by k...@chromium.org, Mar 30 2017 

Issue 705915 has been merged into this issue.

Comment 4 by cl...@chromium.org, Mar 30 2017

Components: UI>Browser>Mobile>NavPanel

Comment 5 by k...@chromium.org, Mar 30 2017

Labels: -Pri-1 Hotlist-Chrome-Home Pri-2
We should figure out a solution here. I'm fine with the idea of 2 snackbar managers. Chris?

Comment 6 by cl...@chromium.org, Mar 31 2017 

Two snackbar managers seems fine to me. Would there be any significant downsides we should consider? I imagine this would imply that when CH is collapsed, any visible snackbars disappear, which seems fine to me.

Comment 7 by mvanouwe...@chromium.org, Apr 3 2017 

"I imagine this would imply that when CH is collapsed, any visible snackbars disappear, which seems fine to me."

Yes, that's exactly what we had in mind. If the user collapses the sheet, by taking a different action, that's a clear signal the snackbar is of little interest.

Comment 8 by twelling...@chromium.org, Apr 6 2017 

I'd like to start eng work on this soon. From a layering perspective, where should the snackbar in CH show up (e.g. above the bottom nav bar)?

Comment 9 by mvanouwe...@chromium.org, Apr 7 2017 

I guess for positioning there's a few options:
1. Above the nav bar, obscuring some sheet content
2. Below the nav bar, causing the nav bar to move up and down :-(
3. On top of the nav bar, obscuring it, and adding additional z-layer depth

I think 1 (your suggestion) seems the best option.

Comment 10 by twelling...@chromium.org, Apr 7 2017

Owner: twelling...@chromium.org
Status: Started (was: Assigned)
Video from in-progress CL
bottom_sheet_snackbars.mp4
6.8 MB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea

commit f23b1c1dcfe30977bf66bdc90584fe59ab6441ea
Author: twellington <twellington@chromium.org>
Date: Mon Apr 10 18:16:28 2017

[Home] Add support for snackbars in the BottomSheet

A second SnackbarManager is used to display snackbars on top
of the bottom sheet.

BUG= 704128 

Review-Url: https://codereview.chromium.org/2806593004
Cr-Commit-Position: refs/heads/master@{#463329}

[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/res/layout/main.xml
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/SnackbarActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSheetContent.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadPage.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSheetContent.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryPage.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/history/HistorySheetContent.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/suggestions/TileGroupDelegateImpl.java
[modify] https://crrev.com/f23b1c1dcfe30977bf66bdc90584fe59ab6441ea/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

Comment 12 by twelling...@chromium.org, Apr 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment