New issue
Advanced search Search tips

Issue 704124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Ensure that v8.infinite_scroll* benchmarks scroll by the same amount

Project Member Reported by u...@chromium.org, Mar 22 2017

Issue description

Some stories in v8.infinite_scroll* can get stuck during scrolling and fail silently. This appears as noise in the results.

We need to ensure that stories scroll by the same amount on each run and fail with exception if scrolling gets stuck.
 
+1 if this check can be implemented in telemetry core
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e17ac4602dc38aaa6a44d4f6d2566920d6c75d

commit 95e17ac4602dc38aaa6a44d4f6d2566920d6c75d
Author: ulan <ulan@chromium.org>
Date: Fri Apr 07 09:00:03 2017

Ensure fixed amount of scrolling in infinite scroll stories.

This patch changes the scrolling logic in the stories such that each
story does the same fixed amount of scrolling in any run.

Apart from that the stories are refactored and unified following the
convention of the system health stories.

PERF SHERIFF NOTE: expect regressions and/or improvements in
- v8.infinite_scroll_tbmv2 (and other variants of this benchmark).
- v8.mobile_infinite_scroll_tbmv2 (and other variants of this benchmark).

BUG= chromium:704124 

Review-Url: https://codereview.chromium.org/2773483002
Cr-Commit-Position: refs/heads/master@{#462813}

[modify] https://crrev.com/95e17ac4602dc38aaa6a44d4f6d2566920d6c75d/tools/perf/benchmarks/v8.py
[modify] https://crrev.com/95e17ac4602dc38aaa6a44d4f6d2566920d6c75d/tools/perf/page_sets/infinite_scroll_cases.py
[delete] https://crrev.com/b63a4f94ae3e6b72ed0107f5525cc48615a0e118/tools/perf/page_sets/mobile_infinite_scroll_cases.py

Comment 3 by u...@chromium.org, Jul 24 2017

Status: Fixed (was: Assigned)
Components: Test>Telemetry
Components: -Speed>Telemetry

Sign in to add a comment