This will allow to run unittests on all platform an reuse the model if needed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52b6cd6ecd26d8978e61fa708dd857c2909e49be commit 52b6cd6ecd26d8978e61fa708dd857c2909e49be Author: olivierrobin <olivierrobin@chromium.org> Date: Thu Mar 23 13:55:54 2017 Move ReadingList model to components/reading_list/core - Needed to rename ERROR enums to DISTILLATION_ERROR as ERROR is defined on Windows. - Needed to fix FILE_PATH_LITERAL for Windows. - Needed to return a default value when returning from an switch for Android. BUG= 704105 Review-Url: https://codereview.chromium.org/2763233003 Cr-Commit-Position: refs/heads/master@{#459067} [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/browser_sync/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/BUILD.gn [add] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/offline_url_utils.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/offline_url_utils.h [add] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/offline_url_utils_unittest.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/proto/BUILD.gn [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/proto/reading_list.proto [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_entry.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_entry.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_entry_unittest.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_impl.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_impl.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_observer.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_storage.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_storage.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_model_unittest.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_pref_names.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_pref_names.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_store.cc [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_store.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_store_delegate.h [rename] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/core/reading_list_store_unittest.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/ios/BUILD.gn [delete] https://crrev.com/f72cfd9f7717eaa5341d7223b01c427cf19bca08/components/reading_list/ios/offline_url_utils.cc [delete] https://crrev.com/f72cfd9f7717eaa5341d7223b01c427cf19bca08/components/reading_list/ios/offline_url_utils_unittest.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/ios/reading_list_model_bridge_observer.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/components/reading_list/ios/reading_list_model_bridge_observer.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/app/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/offline_url_utils.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_download_service.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_download_service.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_model_factory.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_remover_helper.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_remover_helper.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_web_state_observer.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/url_downloader.cc [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/reading_list/url_downloader_unittest.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/share_extension/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/share_extension/share_extension_item_receiver.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/share_extension/share_extension_service.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/share_extension/share_extension_service.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/sync/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/sync/ios_chrome_sync_client.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/tabs/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/activity_services/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/ntp/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller_unittest.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.h [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_collection_view_item.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_coordinator_unittest.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/side_swipe/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/toolbar/BUILD.gn [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/toolbar/tools_menu_button_observer_bridge.mm [modify] https://crrev.com/52b6cd6ecd26d8978e61fa708dd857c2909e49be/ios/chrome/browser/ui/tools_menu/BUILD.gn
Comment 1 by eugene...@chromium.org
, Mar 22 2017