New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704092 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird black patches are seen on save dialog when GTK+ theme is high contrast

Project Member Reported by sc00335...@techmahindra.com, Mar 22 2017

Issue description

Chrome Version: 59.0.3048.0 
OS: Ubuntu 14.04

URL: https://apps.ubuntu.com/cat/applications/gnome-tweak-tool/

What steps will reproduce the problem?
(1)Add above tool
(2)Now open that tool and change GTK+ theme to High Contrast
(3)Open chrome and hit ctrl+s for save dialog

Expected: No black patches should be seen 
Actual: Instead black patches are seen near horizontal and vertical scrollbar.

This is a regression issue broken in M59.

Good Build: 59.0.3035.0 dev
Bad Build: 59.0.3036.0 dev

NOTE: Issue is not applicable to Windows.
 
Expected_save dialog.png
188 KB View Download
Actual_save dialog.png
190 KB View Download
Another issue is seen with same bisect range.

When save dialog is opened observe colour of chrome tabstrip.

If required will raise separate issue for this.


Labels: -Needs-Bisect hasbisect-per-revision
Owner: thomasanderson@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Ubuntu 14.04 using chrome Dev #59.0.3048.0

Bisect Information:
---------------------
You are probably looking for a change made after 455595 (known good), but no later than 455596 (first known bad).

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/caa6a6165d28c3bb499fc0aec9bf391c6bda1578..072522801041708fba94498a1844cb89f24d4590

From the above change log suspecting below change
Review URL: https://codereview.chromium.org/2670623002

thomasanderson@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 3 by ajha@chromium.org, Mar 22 2017

Labels: ReleaseBlock-Stable
Adding RB-Stable as this is recent regression.
Cc: e...@chromium.org
Labels: -ReleaseBlock-Stable
Status: ExternalDependency (was: Assigned)
The bisect is correct and this issue is a result of switching to the Gtk3 theme.

Unfortunately, this is a Gtk bug and there's not much we can do here.  It was fixed somewhere between Gtk 3.11 and 3.14 based on my testing, but Trusty is at 3.10.  The best-case scenario would be for Canonical to backport the patch onto 3.10.

Luckily, the issue is not seen on the Ambiance theme, which most Googlers use.
Status: Started (was: ExternalDependency)
I think we can add a workaround for the Adwaita/HighContrast case.
Project Member

Comment 6 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c

commit ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c
Author: thomasanderson <thomasanderson@google.com>
Date: Tue May 02 22:49:22 2017

Gtk3: Fix black patches on GtkFileChooser dialogs

This CL fixes parts of GtkFileChoosers not getting rendered on GNOME
standard themes (Adwaita + HighContrast) causing black areas to
appear.

BUG= 704092 
R=erg@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2854773002
Cr-Commit-Position: refs/heads/master@{#468803}

[modify] https://crrev.com/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
[modify] https://crrev.com/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c/chrome/browser/ui/libgtkui/native_theme_gtk3.h
[modify] https://crrev.com/ea8d1f89cb74cd379d78cf276bf6efbc3bf3ba6c/ui/base/glib/scoped_gobject.h

Labels: Merge-Request-59
Project Member

Comment 8 by sheriffbot@chromium.org, May 3 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, May 4 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05ad603540b72d126e19db8c1c2fc5aec53a4b98

commit 05ad603540b72d126e19db8c1c2fc5aec53a4b98
Author: thomasanderson <thomasanderson@google.com>
Date: Thu May 04 02:26:35 2017

[Merge to M59] Gtk3: Fix black patches on GtkFileChooser dialogs

> This CL fixes parts of GtkFileChoosers not getting rendered on GNOME
> standard themes (Adwaita + HighContrast) causing black areas to
> appear.
>
> BUG= 704092 
> R=erg@chromium.org
> TBR=sky@chromium.org
>
> Review-Url: https://codereview.chromium.org/2854773002
> Cr-Commit-Position: refs/heads/master@{#468803}

BUG= 704092 
R=erg@chromium.org
TBR=sky@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2856393002
Cr-Commit-Position: refs/branch-heads/3071@{#390}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/05ad603540b72d126e19db8c1c2fc5aec53a4b98/chrome/browser/ui/libgtkui/gtk_util.h
[modify] https://crrev.com/05ad603540b72d126e19db8c1c2fc5aec53a4b98/chrome/browser/ui/libgtkui/native_theme_gtk3.cc
[modify] https://crrev.com/05ad603540b72d126e19db8c1c2fc5aec53a4b98/chrome/browser/ui/libgtkui/native_theme_gtk3.h
[modify] https://crrev.com/05ad603540b72d126e19db8c1c2fc5aec53a4b98/ui/base/glib/scoped_gobject.h

Status: Fixed (was: Started)
Labels: TE-Verified-59.0.3071.47 TE-Verified-59
verified the issue on Linux Ubuntu-14.04 using chrome version 59.0.3071.47 with the steps mentioned in comment#0.
Observed that the fix is working as expected.hence adding TE-Verified labels.
Please find the attached screen cast for reference for the sama.

Thanks.
issue-704092.mp4
630 KB View Download
Labels: -TE-Verified-59 TE-Verified-M59

Sign in to add a comment