New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704091 link

Starred by 3 users

Issue metadata

Status: Closed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Need to communicate ephemeral status when registering for policy

Project Member Reported by atwilson@chromium.org, Mar 22 2017

Issue description

User policy registration should take a flag that states the session is ephemeral.
 
Labels: -Pri-3 Pri-1
As part of this, I'd also like us to log a UMA histogram that tells us how long it's been since the last policy fetch, per our email conversation. Bumping in priority to try to get in M60.
Cc: -atwilson@chromium.org
Owner: atwilson@chromium.org
Labels: -Type-Bug Type-Feature
Cc: atwilson@chromium.org
Owner: antrim@chromium.org

Comment 5 by antrim@chromium.org, May 15 2017

Labels: OS-Chrome
Status: Started (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b9250eebac7da0cf2138fceffb5af9855090940

commit 4b9250eebac7da0cf2138fceffb5af9855090940
Author: Denis Kuznetsov <antrim@google.com>
Date: Thu Feb 08 15:30:28 2018

Report Ephemeral status upon user policy registration.

Bug= chromium:704091 

Change-Id: Ib14bed7fc3df442aefae4f71f03a75c883150d08
Reviewed-on: https://chromium-review.googlesource.com/704856
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ivan Ĺ andrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535388}
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/login/users/fake_chrome_user_manager.h
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/chromeos/policy/user_policy_test_helper.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/chrome/browser/policy/cloud/cloud_policy_manager_browsertest.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/core/common/cloud/cloud_policy_client.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/core/common/cloud/cloud_policy_client.h
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/core/common/cloud/cloud_policy_client_unittest.cc
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/core/common/cloud/mock_cloud_policy_client.h
[modify] https://crrev.com/4b9250eebac7da0cf2138fceffb5af9855090940/components/policy/proto/device_management_backend.proto

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1319b3d1c72f4dfd4d4c3a569cd7c0bfbbc92f

commit ee1319b3d1c72f4dfd4d4c3a569cd7c0bfbbc92f
Author: Denis Kuznetsov <antrim@google.com>
Date: Thu Mar 15 16:09:06 2018

Add default value to Lifetime enum.

Add unnecessary value containing "DEFAULT" in the name just to
make ProtoBestPractices check happy.

Bug:  704091 
Change-Id: I99e62d9d711eef17a783408c0fbe62b115b7ac68
Reviewed-on: https://chromium-review.googlesource.com/951249
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543379}
[modify] https://crrev.com/ee1319b3d1c72f4dfd4d4c3a569cd7c0bfbbc92f/components/policy/proto/device_management_backend.proto

Status: Fixed (was: Started)
Hi..
Please provide steps if this requires manual verification.
Status: Assigned (was: Fixed)
Owner: chchakrapani@google.com
That is just a flag sent in protobuf upon device registration. There is no any user or admin-facing changes, they are only required to detect and remove unused registrations several years down from now.
Owner: antrim@google.com
Status: Closed (was: Assigned)
Thanks for the details, Closing the issue(WAI) for now.

Sign in to add a comment