New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 704082 link

Starred by 2 users
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2017
Cc:
█ lpromero@chromium.org
gambard@chromium.org
ios-bugs@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 704102



Sign in to add a comment

Have a MDCCollectionViewTextCell working with auto layout

Project Member Reported by gambard@chromium.org, Mar 22 2017 
The CollectionViewTextItem are using MDCCollectionViewTextCell as cellClass.
This CL has a fix positioning, not using auto layout.

In order to allow dynamic type and the usage of auto-detection of cell height, we should have a cell having the same behavior of MDCCollectionViewTextCell but using auto layout.
This cell would be used by the CollectionViewTextItem.

Comment 1 by gambard@chromium.org, Mar 22 2017

Cc: gambard@chromium.org lpromero@chromium.org
 Issue 704087  has been merged into this issue.

Comment 2 by gambard@chromium.org, Mar 22 2017

Components: UI>Settings

Comment 3 by lpromero@chromium.org, Mar 22 2017

Blocking: 704102
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9612c36b6ba03e3f007114bff6347295c7d427

commit 0b9612c36b6ba03e3f007114bff6347295c7d427
Author: gambard <gambard@chromium.org>
Date: Fri Mar 24 09:59:40 2017

Use CollectionViewTextItem instead of a cast

To set the color and the font of the cell handled by a CollectionViewTextItem,
some classes where selecting the cell and casting it to a
CollectionViewTextCell.
This CL sets the style directly in the item.

BUG= 704082 

Review-Url: https://codereview.chromium.org/2768933005
Cr-Commit-Position: refs/heads/master@{#459378}

[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/payments/payment_request_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/autofill_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/privacy_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/save_passwords_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm
[modify] https://crrev.com/0b9612c36b6ba03e3f007114bff6347295c7d427/ios/chrome/browser/ui/settings/translate_collection_view_controller.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90a41e827e84da99b9746f6b9a355aa9e83ab6cd

commit 90a41e827e84da99b9746f6b9a355aa9e83ab6cd
Author: gambard <gambard@chromium.org>
Date: Fri Mar 24 11:59:00 2017

Create CollectionViewTextCell

This CL creates a CollectionViewTextCell having the same behavior as
MDCCollectionViewTextCell but using auto layout.

BUG= 704082 

Review-Url: https://codereview.chromium.org/2764783006
Cr-Commit-Position: refs/heads/master@{#459395}

[modify] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/BUILD.gn
[add] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.h
[add] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/collection_view_text_cell.mm
[modify] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.h
[modify] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item.mm
[modify] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/collection_view/cells/collection_view_text_item_unittest.mm
[modify] https://crrev.com/90a41e827e84da99b9746f6b9a355aa9e83ab6cd/ios/chrome/browser/ui/settings/material_cell_catalog_view_controller.mm

Comment 6 by gambard@chromium.org, Mar 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment