New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704081 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Regression: Ripple effect for 'Import' button appears stuck on Import bookmark overlay

Reported by sans...@etouch.net, Mar 22 2017

Issue description

Chrome Version:58.0.3029.33 (Official Build)  bbd92a163524024087600eeac86ed7fa7ffc77bb-refs/branch-heads/3029@{#350}
OS:Mac OS X(10.11.6,10.12.1)

Steps:
1. Launch Chrome and navigate to chrome://md-settings
2. Click on 'Import bookmarks and settings' and click on 'Import' button
3. Observe the ripple effect on 'Import' button

Actual: Ripple effect for 'Import' button appears stuck after clicking on it

Expected: Ripple effect for 'Import' button should appear properly after clicking on it

This is regression issue, broken in ‘M 56’ and below is narrow bisect:

Good build: 56.0.2923.0
Bad build: 56.0.2924.0

Note: This is Mac OS specific issue, not seen on Windows and Linux OS




 
Actual_video.mov
3.8 MB Download
Expected_video.mov
3.0 MB Download
Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:56.0.2923.0 (Revision:432704).
Bad build:56.0.2924.0 (Revision:433059).

You are probably looking for a change made after 432752 (known good), but no later than 432753 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/a01fff7db87d8570c38a657948f68af0a0e7a3c6..411c9f114fd32cde3b27382c78fdaac5d4e0365f

From the CL above, assigning the issue to the concern owner

@dpapad : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2501783003
Note :Mac Specific issue and Able to reproduce in latest Canary #59.0.3048.0

Comment 2 by dpa...@chromium.org, Mar 22 2017

Cc: dbeam@chromium.org
Labels: -Type-Bug-Regression Proj-MaterialDesign-WebUI Type-Bug
Status: WontFix (was: Assigned)
The "expected" video is running on a version before the "Import" button was not hooked up to any functionality. So I don't think this is a regression.

There is a native system dialog (not a <dialog>) showing up which pauses any JS running on the page (see screenshot), which in turn causes the ripple to stop animating. I don't think there is anything we can do on our side to make the ripple  continue animating, while JS is paused.
screenshot.png
316 KB View Download

Comment 3 by dbeam@chromium.org, Mar 23 2017

we could wait for a 'transitionend' event from the on-tap handler, just like we do for the CHANGE button in downloads, btw

Sign in to add a comment