New issue
Advanced search Search tips

Issue 704080 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 9
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 822361
issue 823242

Blocking:
issue 407399
issue v8:7441



Sign in to add a comment

Migrate lkgr_finder off master1

Project Member Reported by machenb...@chromium.org, Mar 22 2017

Issue description

Tracker bug. This is to get the script running on a slave instead of the master.

Projects like webrtc and v8 could migrate right away. Chromium's lkcr can't migrate due to a file that's published on master1.
 
Some CLs for migrating V8.

Puppet CL to add creds:
https://chrome-internal-review.googlesource.com/c/338787/

Infra CL with recipe:
https://chromium-review.googlesource.com/c/458399/

TODO:
Add bot to client.v8.fyi, remove v8 cron job from master1.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/e72d5a8525a9231e35f98e49fa0bcc2c6c295e86

commit e72d5a8525a9231e35f98e49fa0bcc2c6c295e86
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 14:40:47 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4d434d5150103eb6e1298118dd99d41e9e81afae

commit 4d434d5150103eb6e1298118dd99d41e9e81afae
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 15:03:48 2017

V8: Add lkgr-finder bot

BUG= chromium:704080 

Change-Id: Ieee90f78221bc115c709e03c99f1f533e01ac08c
Reviewed-on: https://chromium-review.googlesource.com/458279
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/4d434d5150103eb6e1298118dd99d41e9e81afae/masters/master.client.v8.fyi/master.cfg
[modify] https://crrev.com/4d434d5150103eb6e1298118dd99d41e9e81afae/masters/master.client.v8.fyi/slaves.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/007f604ff6d456d3518a784b1c2aa393bcf908db

commit 007f604ff6d456d3518a784b1c2aa393bcf908db
Author: Michael Achenbach <machenbach@google.com>
Date: Wed Mar 22 15:20:38 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/46d2334a3cff3529f26c45238ef9b8f77637470c

commit 46d2334a3cff3529f26c45238ef9b8f77637470c
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 15:25:47 2017

Add lkgr_finder wrapper recipe

BUG= chromium:704080 

Change-Id: I71f2554a3e025e463841ad6921d30cef27a5a3df
Reviewed-on: https://chromium-review.googlesource.com/458399
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/46d2334a3cff3529f26c45238ef9b8f77637470c/recipes/recipes/lkgr_finder.py
[add] https://crrev.com/46d2334a3cff3529f26c45238ef9b8f77637470c/recipes/recipes/lkgr_finder.expected/v8.json

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0b628ce55182bb3240e8d233e1b9f68c80309725

commit 0b628ce55182bb3240e8d233e1b9f68c80309725
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 15:59:34 2017

V8: Fix properties for lkgr finder

BUG= chromium:704080 
TBR=tandrii@chromium.org

Change-Id: I5dce42d186334915b83f34df7db870f76f877261
Reviewed-on: https://chromium-review.googlesource.com/458352
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/0b628ce55182bb3240e8d233e1b9f68c80309725/masters/master.client.v8.fyi/master.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/5e1cc31f8bdda7aac1034652693fa3cf1485a0bb

commit 5e1cc31f8bdda7aac1034652693fa3cf1485a0bb
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 16:01:07 2017

Fix properties for lkgr finder recipe

BUG= chromium:704080 
TBR=tandrii@chromium.org

Change-Id: I4b4ec7862ef02487fd8de6f58f455020c2d73ed0
Reviewed-on: https://chromium-review.googlesource.com/458478
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/5e1cc31f8bdda7aac1034652693fa3cf1485a0bb/recipes/recipes/lkgr_finder.py

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b2dd7158f12e9f612d9dc13c01ad0315ff758c16

commit b2dd7158f12e9f612d9dc13c01ad0315ff758c16
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 16:32:38 2017

Move lkgr_finder properties into recipe

BUG= chromium:704080 

Change-Id: Ib8e45b5e9f54bc258e6a66bf49c6ff5367122f48
Reviewed-on: https://chromium-review.googlesource.com/458217
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b2dd7158f12e9f612d9dc13c01ad0315ff758c16/recipes/recipes/lkgr_finder.py

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/b2dd7158f12e9f612d9dc13c01ad0315ff758c16

commit b2dd7158f12e9f612d9dc13c01ad0315ff758c16
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 22 16:32:38 2017

Move lkgr_finder properties into recipe

BUG= chromium:704080 

Change-Id: Ib8e45b5e9f54bc258e6a66bf49c6ff5367122f48
Reviewed-on: https://chromium-review.googlesource.com/458217
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b2dd7158f12e9f612d9dc13c01ad0315ff758c16/recipes/recipes/lkgr_finder.py

And it works:
https://build.chromium.org/p/client.v8.fyi/builders/V8%20lkgr%20finder/builds/6

Now V8 runs lkgr finder on a slave on V8 waterfall. I will wait a bit with submitting the cron removal on master1 to see how stable this is.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aed5b8dbeddc21dec1db33d0079c137a4131a2a6

commit aed5b8dbeddc21dec1db33d0079c137a4131a2a6
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 23 15:02:28 2017

Let lkgr-finder recipe upload lkgr-status

BUG= chromium:704080 

Change-Id: I12880a37b44e3d9fe2e5e628a3c3ae91a2b2e2bf
Reviewed-on: https://chromium-review.googlesource.com/458426
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/aed5b8dbeddc21dec1db33d0079c137a4131a2a6/recipes/recipes/lkgr_finder.py
[modify] https://crrev.com/aed5b8dbeddc21dec1db33d0079c137a4131a2a6/recipes/recipes/lkgr_finder.expected/v8.json

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4c038187f76a62f8df5ac09767e6d8f2424c8240

commit 4c038187f76a62f8df5ac09767e6d8f2424c8240
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 23 15:21:08 2017

Allow to directly view lkgr-status html

BUG= chromium:704080 
TBR=tandrii@chromium.org,iannucci@chromium.org

Change-Id: I3e876cd038c04f1ad8f6af49c31dfe81f3b98150
Reviewed-on: https://chromium-review.googlesource.com/458281
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/4c038187f76a62f8df5ac09767e6d8f2424c8240/recipes/recipes/lkgr_finder.py
[modify] https://crrev.com/4c038187f76a62f8df5ac09767e6d8f2424c8240/recipes/recipes/lkgr_finder.expected/v8.json

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/4b7a890837c00c733c351f8af6dbe74f27eaa878

commit 4b7a890837c00c733c351f8af6dbe74f27eaa878
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 30 10:28:11 2017

Blockedon: v8:7441
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/397da7d50b0a73c76e1cbf1e11d79c255298010e

commit 397da7d50b0a73c76e1cbf1e11d79c255298010e
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 10:34:53 2018

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/df0555d9a9c2f69aa5d0fc3df944517acc483885

commit df0555d9a9c2f69aa5d0fc3df944517acc483885
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 11:38:37 2018

[lkgr] Add lkgr-finder builder

Part of step 4 of:
 https://crbug.com/407399#c31 

The builder will share the slave of the lkgr-tag-pusher until that
one gets deprecated.

Bug:  704080 
Change-Id: I5cffe1694db0aead578a82d6ecaea5100ebbc17d
Reviewed-on: https://chromium-review.googlesource.com/962144
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/df0555d9a9c2f69aa5d0fc3df944517acc483885/masters/master.chromium.infra.cron/slaves.cfg
[modify] https://crrev.com/df0555d9a9c2f69aa5d0fc3df944517acc483885/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 18 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8c6d3ce9deeab73de7aa0404a5d8e6f1baff1b0f

commit 8c6d3ce9deeab73de7aa0404a5d8e6f1baff1b0f
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 11:52:47 2018

[lkgr] Use better name for lkgr-finder builder

Follow up after:
https://crrev.com/c/962144

TBR=sergiyb@chromium.org

Bug:  704080 
Change-Id: Ifaaf6d4a0982d08ffe92096a7237752f7997a8fa
Reviewed-on: https://chromium-review.googlesource.com/962246
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/8c6d3ce9deeab73de7aa0404a5d8e6f1baff1b0f/masters/master.chromium.infra.cron/slaves.cfg
[modify] https://crrev.com/8c6d3ce9deeab73de7aa0404a5d8e6f1baff1b0f/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 19 by bugdroid1@chromium.org, Mar 14 2018

Project Member

Comment 20 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/32261c10a3581e330fe174b798cf129f3a993fb1

commit 32261c10a3581e330fe174b798cf129f3a993fb1
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 12:10:02 2018

[lkgr] Migrate Chromium's lkcr to lkgr

First part of:
 https://crbug.com/407399#c31 

NOTREECHECKS=true

Bug:  704080 
Change-Id: Ic74c803ced3264a94944f2d3ba0e7f694e8b627a
Reviewed-on: https://chromium-review.googlesource.com/962142
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/32261c10a3581e330fe174b798cf129f3a993fb1/infra/services/lkgr_finder/config/chromium_cfg.pyl

Project Member

Comment 21 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/8f74cb092c5f5e2ca53a7691d74da6bab2c47021

commit 8f74cb092c5f5e2ca53a7691d74da6bab2c47021
Author: Michael Achenbach <machenbach@google.com>
Date: Wed Mar 14 12:11:53 2018

Project Member

Comment 22 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/7198c35e2efa0906ee832d086fccdeb59adb77ac

commit 7198c35e2efa0906ee832d086fccdeb59adb77ac
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 14:25:27 2018

[lkgr] Add lkgr-finder to scheduler config

Follow up after:
https://crrev.com/c/962144

TBR=sergiyb@chromium.org

Bug:  704080 
Change-Id: I94d7de1da8942c4aa1f837b1dca5094763d59eff
Reviewed-on: https://chromium-review.googlesource.com/962448
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/7198c35e2efa0906ee832d086fccdeb59adb77ac/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 23 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/c2633254635e9c4c360aacda3320f7c073125d05

commit c2633254635e9c4c360aacda3320f7c073125d05
Author: Michael Achenbach <machenbach@google.com>
Date: Wed Mar 14 14:33:22 2018

Project Member

Comment 24 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/22730436dadffead928bfac22b2f38f8cb2f802a

commit 22730436dadffead928bfac22b2f38f8cb2f802a
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 14:38:32 2018

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4512a04db4017c7dfd110e3fb02d5c73653d72ea

commit 4512a04db4017c7dfd110e3fb02d5c73653d72ea
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 14 22:08:18 2018

[lkgr] Only clone project repos, don't gclient sync

Previously, the lkgr-finder recipe did a full checkout of the project
repo, including gclient sync of all DEPS. This is not necessary for
pushing the lkgr ref.

Bug:  704080 
Change-Id: I428448b5b8a8ba4c06064c6eda5940653a81d571
Reviewed-on: https://chromium-review.googlesource.com/963521
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.expected/chromium.json
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.expected/webrtc.json
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.py
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/README.recipes.md
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.expected/webrtc_lkgr_failure.json
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.expected/v8.json
[modify] https://crrev.com/4512a04db4017c7dfd110e3fb02d5c73653d72ea/recipes/recipes/lkgr_finder.expected/webrtc_lkgr_stale.json

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4265d42cf8c4c315cbec23e21d8f42b9e2bd36d2

commit 4265d42cf8c4c315cbec23e21d8f42b9e2bd36d2
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 15 08:53:46 2018

[lkgr] Temporarily remove breaking builders from Chromium lkgr

TBR=sergiyb@chromium.org

Bug:  704080 
Change-Id: I7ba995a6d278c1fef647076b8f56fe757dbca246
Reviewed-on: https://chromium-review.googlesource.com/964041
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/4265d42cf8c4c315cbec23e21d8f42b9e2bd36d2/infra/services/lkgr_finder/config/chromium_cfg.pyl

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 15 2018

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4c420d8bfd51e7023c04c651ecc8348d7b71593d

commit 4c420d8bfd51e7023c04c651ecc8348d7b71593d
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Mar 15 11:52:06 2018

[V8] Switch chromium builders from lkcr to lkgr

Step 2 of:
 https://crbug.com/407399#c31 

Bug:  704080 
Change-Id: I4e6a71ee1051b8a91b2d2913279aeff0f958ce64
Reviewed-on: https://chromium-review.googlesource.com/964161
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipe_modules/chromium_tests/client_v8_fyi.py
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipe_modules/chromium/gclient_config.py
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipe_modules/chromium/tests/gclient.py
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/README.recipes.md
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipes/android/builder.expected/full_client_v8_fyi_Android_Builder.json
[modify] https://crrev.com/4c420d8bfd51e7023c04c651ecc8348d7b71593d/scripts/slave/recipes/android/builder.py

Blockedon: 822361
Blockedon: 823242
Blockedon: -v8:7441
Blocking: v8:7441
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/bd6f6f9bbc7a3a7ea7e8723df2de178887417dc7

commit bd6f6f9bbc7a3a7ea7e8723df2de178887417dc7
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 19 10:42:41 2018

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 19 2018

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/620f79f01654719ab7321fb8177aa524c3e07e35

commit 620f79f01654719ab7321fb8177aa524c3e07e35
Author: Michael Achenbach <machenbach@google.com>
Date: Mon Mar 19 11:00:54 2018

Project Member

Comment 36 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/6fd9a14cc8104f0eef1ef60ebb3289054c5c2eb4

commit 6fd9a14cc8104f0eef1ef60ebb3289054c5c2eb4
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Mar 19 13:10:08 2018

Project Member

Comment 37 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7aec1f9d47040cad97c018f80cff75876a9aa6b8

commit 7aec1f9d47040cad97c018f80cff75876a9aa6b8
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 21 08:05:38 2018

[lkgr] Deprecate lkgr status-app post

The only users of lkgr-finder now use the read-from/write-to file option
and afterwards directly update a ref in their git repo.

Hence, we deprecate using the status-app for storing the lkgr. This
unblocks removing corresponding code from the status-app.

Step 7 of:
 https://crbug.com/407399#c31 

Bug:  704080 ,760305
Change-Id: Ibc65265efb632ad76e5b0d619dca6265d8c455b8
Reviewed-on: https://chromium-review.googlesource.com/968422
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/7aec1f9d47040cad97c018f80cff75876a9aa6b8/infra/services/lkgr_finder/__main__.py
[modify] https://crrev.com/7aec1f9d47040cad97c018f80cff75876a9aa6b8/infra/services/lkgr_finder/lkgr_lib.py

Project Member

Comment 38 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/67eebdbb582a429e72634055c9dd39ae3e367b75

commit 67eebdbb582a429e72634055c9dd39ae3e367b75
Author: Michael Achenbach <machenbach@chromium.org>
Date: Wed Mar 21 09:24:29 2018

Revert "[lkgr] Deprecate lkgr status-app post"

This reverts commit 7aec1f9d47040cad97c018f80cff75876a9aa6b8.

Reason for revert: https://crbug.com/824080

Original change's description:
> [lkgr] Deprecate lkgr status-app post
> 
> The only users of lkgr-finder now use the read-from/write-to file option
> and afterwards directly update a ref in their git repo.
> 
> Hence, we deprecate using the status-app for storing the lkgr. This
> unblocks removing corresponding code from the status-app.
> 
> Step 7 of:
>  https://crbug.com/407399#c31 
> 
> Bug:  704080 ,760305
> Change-Id: Ibc65265efb632ad76e5b0d619dca6265d8c455b8
> Reviewed-on: https://chromium-review.googlesource.com/968422
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>

TBR=iannucci@chromium.org,agable@chromium.org,machenbach@chromium.org,sergiyb@chromium.org

Change-Id: Iaa58947b75a63ac4d57f7caf7e63a2bf2e2f3df6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  704080 , 760305
Reviewed-on: https://chromium-review.googlesource.com/972382
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/67eebdbb582a429e72634055c9dd39ae3e367b75/infra/services/lkgr_finder/__main__.py
[modify] https://crrev.com/67eebdbb582a429e72634055c9dd39ae3e367b75/infra/services/lkgr_finder/lkgr_lib.py

Project Member

Comment 40 by bugdroid1@chromium.org, Apr 6

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/47c17bc164bfdfca263c4fec30e50b1cc30c3207

commit 47c17bc164bfdfca263c4fec30e50b1cc30c3207
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Apr 06 18:43:41 2018

Reland "[lkgr] Deprecate lkgr status-app post"

This is a reland of 7aec1f9d47040cad97c018f80cff75876a9aa6b8

The status app code is still removed, but if the current lkgr is
not read from a file, it is instead initialized to a dummy value,
which is the status quo.

Original change's description:
> [lkgr] Deprecate lkgr status-app post
>
> The only users of lkgr-finder now use the read-from/write-to file option
> and afterwards directly update a ref in their git repo.
>
> Hence, we deprecate using the status-app for storing the lkgr. This
> unblocks removing corresponding code from the status-app.
>
> Step 7 of:
>  https://crbug.com/407399#c31 
>
> Bug:  704080 ,760305
> Change-Id: Ibc65265efb632ad76e5b0d619dca6265d8c455b8
> Reviewed-on: https://chromium-review.googlesource.com/968422
> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>

Bug:  704080 , 760305, 824080
Change-Id: Id507bcd82d3c2d3cff00b88764c86c21ab4e1eff
Reviewed-on: https://chromium-review.googlesource.com/998357
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/47c17bc164bfdfca263c4fec30e50b1cc30c3207/infra/services/lkgr_finder/__main__.py
[modify] https://crrev.com/47c17bc164bfdfca263c4fec30e50b1cc30c3207/infra/services/lkgr_finder/lkgr_lib.py

Project Member

Comment 41 by bugdroid1@chromium.org, Apr 9

Project Member

Comment 42 by bugdroid1@chromium.org, Apr 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/7fff571ad5c68f170ffdd3abfff1d5d957801cf2

commit 7fff571ad5c68f170ffdd3abfff1d5d957801cf2
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Apr 09 08:04:37 2018

Status: Verified (was: Started)

Sign in to add a comment