ChromeOS OOBE: CFM Welcome screen looks strange |
|||||||||||||||||||
Issue descriptionThe first attachment is how it looks now (because the box with header text is center-aligned). The second screenshot is what we will get if we also align the text itself to the center. Also this text depends on device locale, so it may grow/shrink. What do you think? How should we adjust text display for the welcome screen?
,
Mar 23 2017
,
Mar 24 2017
I think it's probably fine to keep the text, but let's update to the font size Elizabeth specified above.
,
Apr 6 2017
What do you mean by "leading" ? I interpreted it as "the first line font size must be 40px, and all the other lines font size must be 32px". Here are screenshots for "font-size: 32px; font-align: center;" and 40px for the first line (see below). The first four screenshots are examples of "Welcome" screen for CfM devices in different languages.
,
Apr 6 2017
Please note that due to the different lengths of words and string in total, the picture looks very different. If I reduce heading width to 500px to make English looks like your example, the result will be different (see below).
,
Apr 6 2017
Please note that text in #14 occupies three lines, which moves the illustration down. So we probably do not want to reduce message width. WDYT?
,
Apr 6 2017
Please note that I did not update font-weight, because we were already using font-weight: 300 (which is light). The last 8 screenshots were taken on a device, so font should be correct.
,
Apr 6 2017
Hey Alexander, I believe leading in this case refers to the line-height, specifically the height between the base lines. So all the text should be size 32sp, with a line-height of 40sp. (Elizabeth, correct me if that's wrong).
,
Apr 8 2017
Here are the screenshots.
,
Apr 8 2017
,
Apr 9 2017
The English one looks weird. Is it possible to match the screenshot I sent? Take out the period at the end, and avoid having "up" hanging on the second line. The title should not go beyond the button on the left. Would you mind to make the left and right margin of the title to be 180?
,
Apr 11 2017
The title never gets beyond the buttons. See the screenshots of container borders attached.
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48d63103e76cc388b4fe5151b2cb66d8af56bbaf commit 48d63103e76cc388b4fe5151b2cb66d8af56bbaf Author: alemate <alemate@chromium.org> Date: Tue Apr 11 08:16:34 2017 ChromeOS OOBE: Update Welcome dialog to better accomodate CfM messages. CfM uses longer elcoming text so this Cl makes the presentation better. BUG= 704059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2806983002 Cr-Commit-Position: refs/heads/master@{#463573} [modify] https://crrev.com/48d63103e76cc388b4fe5151b2cb66d8af56bbaf/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
,
Apr 11 2017
As discussed with zalcorn@ offline, we cannot update strings for M58, so we will just narrow the width of the header by some reasonable amount. So this is fixed.
,
Apr 11 2017
This bug requires manual review: We are only 13 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 11 2017
For the French one, looks like 1-2 words can go to the first line. The title should be able to fit just 2 lines. As for the Arabian screen, can we add the same spacing as English version between the text and the icon in the buttons at the bottom?
,
Apr 12 2017
> For the French one, looks like 1-2 words can go to the first line. We cannot do any hacks for one language. We can only implement some general rule. Right now the rule (from /cros-oobe-spec) says: the baseline of the first line of the header text starts 152 pixels from the top of the dialog. The width of the header was unspecified, but on the last screenshots it is "768-(125*2) = 568px". The top of the illustration is bound to the baseline of the first line of the header. We can implement another layout, but we need a design for it.
,
Apr 12 2017
Thanks for letting me know. It's because I did not know that we need other headers for CFM in the beginning. For chromebooks, we only use "welcome" and that works well in different languages. If this is the case, I need all the strings for different languages and make sure all of them look good. Would you mind to provide me all the headers in different languages?
,
Apr 13 2017
You can find all of them in Translation console: https://tc.corp.google.com/btviewer/messagedetail?project=ChromeClient&msgId=3777371298162501888
,
May 12 2017
,
Jul 20 2017
No need to update M58.
,
Jan 22 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by elizabethchiu@chromium.org
, Mar 23 2017