Thanks for the feedback; we'll be refactoring that whole flow once we launch publicly, I'll ensure this bug is fixed prior to that.

Out of curiosity, why do you have @webrtc and @chromium accounts for different CLs?  Is that a common pattern with the WebRTC team?  I'd like to know how prevalent this is, to understand if your suggestion (include commits for both accounts) is something that would be universally useful for your team and others (e.g. skia, v8).

I work mainly with the webrtc repo, and commit using my @webrtc account. Occasionally, I make changes also to the chromium repo, and then I use my @chromium account.

My main use case for chromiumdash is to find out in which Chrome milestone includes which of my webrtc commits, and currently it seems I need to sign in using my webrtc account to get that list. 

I think this way of working is common in the webrtc team.

Sometimes, webrtc and chromium changes have intimate dependencies, e.g, my recent change starting with https://codereview.webrtc.org/2696703009. Then it would be nice to see these changes together in chromiumdash (but probably not essential; since the main question would be in which milestone the *final* change in the series was included).

Thanks!

I think the search feature on Commits list view on chromiumdash-staging instance should address this issue.
Please correct me if it doesn't 
https://chromiumdash-staging.googleplex.com/commits

I had a look, and I still find the login a bit confusing. Initially, I think I'm not logged in. When I click the icon at the top right, I get to the accounts.google.com sign in dialog.

After signing in as nisse@webrtc.org, I get back to the commit page, which now has the search "user:nisse@webrtc.org" as the default. If I hoover on the top right button, I can see the name of my logged in account. If I click the button, I don't get a "switch account" menu as I'm used to, e.g., on mail.google.com. Instead, I'm immediately logged out.

As for search, user:nisse@webrtc.org shows my webrtc commits, while user:nisse@chromium.org shows my (few) chromium commits. I tried searching for "user:nisse@webrtc.org user:nisse@chromium.org" to try to get both sets of commits in the same list, but that didn't work, that shows @chromium commits only.  

So in summary:

1. It looks prettier, and I no longer need to log in with my @google account. That's nice.

2. The meaning and purpose of sign in is still somewhat confusing. Only effect I've observed so far is the default search on the commit page, and I really shouldn't need to provide any credentials for that.

3. I see no obvious way to get commits for two users, e.g., nisse@webrtc.org and nisse@chromium.org, organized in the same list. 

4. Just clicking on the top-left button should not imply an immediate logout. It should either be labelled as a logout button, or fold out a menu or dialog with logout as one of the options. 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/6523011926b0bd34a9b3fb349f3ce2149ad78ce5

commit 6523011926b0bd34a9b3fb349f3ce2149ad78ce5
Author: Alex Mineer <amineer@google.com>
Date: Mon Sep 25 17:58:01 2017

Moving this to be a stable blocker because the staging instance (https://chromiumdash-staging.googleplex.com/) has been refactored to account for this feedback.

 - The "commits" page now keys off your signed-in ID if you've logged in, but lets you search for any commit from any user, so you can now see different user's CLs without having to log in and out.  We don't support multi-user queries just yet but we might one day.

 - The "bugs" page does still require a login and only shows bugs for whoever is logged in.  We'll address this by adding "search" functionality for the bugs page much like the commits page has.  In the interim, I've added an explicit disclaimer pointing folks to this bug so they understand what's up.

PTAL and let us know if you have further feedback; thanks for helping us improve Chromium Dash!

(and also, please note the staging instance will be deployed to production in the next few weeks - ASAP really).

Updating bug title to reflect pending work.

It'd be nice if we could clean up the sign-in chip to be a bit more consistent with other Google products - maybe we can utilize Monorail or Gerrit's implementation.  Simply having the user icon log you out immediately is jarring, and letting users select a second account from there would be more intuitive.

We should also support multi-account where we can, as described in c#5 (point 3) above and the bug I'm about to dupe into this issue.  Unfortunately we can't assume <username> is consistent across @chromium.org, @google.com, @webrtc.org e-mail addresses, so we might be a bit limited in this space.  Also, different accounts may have varying Monorail permissions, so bug querying might be hard too.

 Issue 804378  has been merged into this issue.

I got a scary warning when logging in to the bugs page with my chromium app - it said 'this app has not been verified by google' or something, and I had to click 'Advanced' to bypass.

Presumably the app will be approved and the warning will go away by the time this tool is rolled out more widely?

*chromium account, not app

awdf@, please see https://bugs.chromium.org/p/chromium/issues/detail?id=807749#c6 for why you're seeing this and how to fix it.  New users to Chromium Dash shouldn't experience this issue, only folks who accessed it in the past. 

No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!

ahmeaali4@gmail.com