New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 704042 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Delayed response for 'Internet connection' section is seen while chrome://md-settings page is loading.

Project Member Reported by jbanavatu@chromium.org, Mar 22 2017

Issue description

Chrome Version: 58.0.3029.31/9334.18.0 dev channel Daisy,Candy,Minnie
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign in to chrome>>Open  or reload chrome://md-settings page and Observe Internet connection section.

Expected: All the sections should load at the same time without any delay.
Actual: Instead, Delayed response for 'Internet connection' section is seen.

This is regression issue as same is working fine in M57.

Note: Issue is also seen in M59.

Attaching screen-cast for reference.
 
Actual.webm
816 KB View Download

Comment 1 by r...@chromium.org, Apr 7 2017

Labels: -Pri-1 Pri-3
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
This is mostly WAI. The network information is queried asynchronously and filled in when available. There may be an opportunity to make some improvements here, so I will leave this open as a P3.

Status: Started (was: Assigned)
Labels: -M-59 M-60
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3b1b256fd85fa0c846e49240e681d4f5cee91f7

commit e3b1b256fd85fa0c846e49240e681d4f5cee91f7
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Apr 18 18:49:28 2017

MD Settings: Elim is-list-item from cr-network-list-item

Currently we use cr-network-list-item in two ways:
1. As a summary for the ntetwork type (e.g. WiFi) in the Settings UI.
2. As an item in a list of networks in Settings and OOBE.

Use case #1 complicates the code and adds extra complexity to the main
Settings UI page. Eliminating it simplifies the code with only a small
amount of duplication. It also allows more flexibility in customizing
the main Settings page layout.

BUG= 704042 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2824493003
Cr-Commit-Position: refs/heads/master@{#465302}

[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/settings/internet_page/compiled_resources2.gyp
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/settings/internet_page/network_summary_item.html
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/settings/internet_page/network_summary_item.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/resources/settings/settings_ui/settings_ui.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/chrome/test/data/webui/settings/internet_page_tests.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/ui/webui/resources/cr_elements/network/cr_network_list.html
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/ui/webui/resources/cr_elements/network/cr_network_list_item.html
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/ui/webui/resources/cr_elements/network/cr_network_list_item.js
[modify] https://crrev.com/e3b1b256fd85fa0c846e49240e681d4f5cee91f7/ui/webui/resources/cr_elements/network/cr_onc_types.js

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49

commit ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49
Author: stevenjb <stevenjb@chromium.org>
Date: Wed Apr 19 01:09:31 2017

MD Settings: Network: Provide default WiFi network

All Chrome OS devices have WiFi, which is typically enabled.

This CL initializes CrNetworkSummary with a WiFi entry so
that in the typical case there is less change between the
initial page layout and when the network state information
arrives from Chrome.

BUG= 704042 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823563004
Cr-Commit-Position: refs/heads/master@{#465453}

[modify] https://crrev.com/ac063b434a2dbfe7bb777fc5fc0bfade5db9aa49/chrome/browser/resources/settings/internet_page/network_summary.js

Status: Fixed (was: Started)
This should be vastly improved from where it was. Marking as fixed.

Status: Verified (was: Fixed)
Chrome OS 9532.0.0, 60.0.3092.0

Sign in to add a comment